Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chutzpah #4249

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Remove chutzpah #4249

merged 5 commits into from
Jan 20, 2023

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jan 6, 2023

Description

Remove chutzpath from the list of tested frameworks and replace it with our own framework that is chosen for running .js files, and does fake discovery and run to prove that we can delegate run of .js files to dotnet testhost.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

  • I have ensures that there is a previously discussed and approved issue.

@nohwnd nohwnd closed this Jan 17, 2023
@nohwnd nohwnd reopened this Jan 17, 2023
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csproj project is seen as "binary" file, I think there is a gitconfig issue. Could you please fix it and readd the project as normal content file?

Otherwise PR lgtm

test/TestAssets/NonDll.TestAdapter/TestAdapter.cs Outdated Show resolved Hide resolved
test/TestAssets/NonDll.TestAdapter/TestAdapter.cs Outdated Show resolved Hide resolved
nohwnd and others added 2 commits January 19, 2023 13:46
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@nohwnd
Copy link
Member Author

nohwnd commented Jan 19, 2023

The project was encoded as utf-16, we have multiple of those in our solution, not sure how that happened. Fixed the encoding in header and the actual encoding.

Let's fix the rest of files in separate PR #4266

@nohwnd nohwnd marked this pull request as ready for review January 19, 2023 13:17
@nohwnd nohwnd enabled auto-merge (squash) January 19, 2023 13:17
@nohwnd nohwnd merged commit 7a0d49c into microsoft:main Jan 20, 2023
Evangelink added a commit to Evangelink/vstest that referenced this pull request Jan 31, 2023
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Evangelink added a commit that referenced this pull request Jan 31, 2023
Co-authored-by: Jakub Jareš <me@jakubjares.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants