Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build macro format tool #842

Closed
wants to merge 3 commits into from
Closed

Add build macro format tool #842

wants to merge 3 commits into from

Conversation

kennykerr
Copy link
Collaborator

Adds a simple tool that can format build macros. I'll create a separate PR to update the build macros to use {} instead of () and perhaps we can use the yml trick from #828 to verify in CI builds. What do you think @MarijnS95?

@MarijnS95
Copy link
Contributor

What do you think @MarijnS95?

Disappointed. I just started writing the same to update #828 - not sure why you're doing duplicate work, is there that much priority to get this in? I don't think I stated anywhere to need help or not have time to "rewrite" the script.

@kennykerr
Copy link
Collaborator Author

kennykerr commented Jun 7, 2021

Sorry, I didn't realize you were working on that. I didn't know how else to describe what I was looking for. It took a few minutes so I thought I'd just take a stab at it. No hurry, so if you've got something in the works I'm happy to wait for that. Let me know.

@MarijnS95
Copy link
Contributor

MarijnS95 commented Jun 7, 2021

@kennykerr Sorry, no harm done - I might have overreacted a bit. The PR is now updated with the script in its entirety ported to Rust, dealing with the generate! macro as well. Let me know if, and if so how to split it up:

  1. Use {} everywhere;
  2. Add the script;
  3. format all macros with it;
  4. Enforce the script in the CI (yml ""trick"" 😀).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants