Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further source integrity checks #481

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Jul 6, 2020

Change

This change requires that the source is coming from an HTTPS location, and that the source package data has been verified for integrity locally before being used.

Validation

Added E2E test for HTTP source. Tampering with package is much harder.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner July 6, 2020 23:57
@JohnMcPMS JohnMcPMS requested a review from yao-msft July 6, 2020 23:57
Copy link
Contributor

@msftrubengu msftrubengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit dd840a8 into microsoft:master Jul 7, 2020
@JohnMcPMS JohnMcPMS deleted the verifypackage branch July 7, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants