-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more than one manifest per PR #125
Comments
This comment has been minimized.
This comment has been minimized.
I would also like to add that if this is implemented, it should allow for both deletions and additions in the same PR. This would make moving packages to new identifiers a lot easier |
* Create Bug_Report Template * updating Updated name for windows feedback and help command
We are looking to start with a maximum of 8 manifests per PR. We will need to track all of the individual validations, and report on any that fail. All manifests and packages must pass validation to be merged in. |
I entirely missed the plan to increment in binary progression. I completely agree with the plan here.
Related: |
Description of the new feature/enhancement
Today in order to submit a PR for a manifest, I can only do 1 at a time. This is inefficient. I would like to be able to have the ability to submit multiple Manifests in one PR.
For example if I am adding a new application, I may have one or more older builds I want to submit. See Windows SDK for example:
17134, 17763, 19041, 18362
Or maybe I have multiple projects that release at one time like a suite, and each app would have its own manifest. I should be able to submit them all.
Proposed technical implementation details (optional)
I expect a submission to process each manifest individually. This should be treated like a normal PR. If the full submission does not pass, it is OK to fail the submission. Similar to code. However the BOT should communicate which manifest failed an why.
If the submission passes, then all manifests should be ingested.
The initial limit will be 8 manifests per PR. We're going to increment in binary progression.
The text was updated successfully, but these errors were encountered: