Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than one manifest per PR #125

Open
denelon opened this issue May 15, 2020 · 4 comments
Open

Support more than one manifest per PR #125

denelon opened this issue May 15, 2020 · 4 comments
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@denelon
Copy link
Contributor

denelon commented May 15, 2020

Description of the new feature/enhancement

Today in order to submit a PR for a manifest, I can only do 1 at a time. This is inefficient. I would like to be able to have the ability to submit multiple Manifests in one PR.

For example if I am adding a new application, I may have one or more older builds I want to submit. See Windows SDK for example:
17134, 17763, 19041, 18362

Or maybe I have multiple projects that release at one time like a suite, and each app would have its own manifest. I should be able to submit them all.

Proposed technical implementation details (optional)

I expect a submission to process each manifest individually. This should be treated like a normal PR. If the full submission does not pass, it is OK to fail the submission. Similar to code. However the BOT should communicate which manifest failed an why.

If the submission passes, then all manifests should be ingested.

The initial limit will be 8 manifests per PR. We're going to increment in binary progression.

@denelon denelon added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 15, 2020
@denelon denelon linked a pull request May 15, 2020 that will close this issue
@denelon denelon added this to the Packages Backlog milestone Jun 3, 2020
@denelon denelon added the Area-Validation-Pipeline Issues related to the manifest validation pipeline. label Jan 6, 2021
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 13, 2021
@ghost

This comment has been minimized.

@denelon denelon removed the No-Recent-Activity No activity has occurred on this work item for seven days. label May 21, 2021
@Trenly
Copy link
Contributor

Trenly commented Oct 15, 2021

I would also like to add that if this is implemented, it should allow for both deletions and additions in the same PR. This would make moving packages to new identifiers a lot easier

seejdev pushed a commit to seejdev/winget-pkgs that referenced this issue Nov 4, 2021
* Create Bug_Report Template

* updating

Updated name for windows feedback and help command
denelon pushed a commit that referenced this issue Dec 1, 2021
* Fix Architecture Overwriting (#129)

* Preserve Product Codes on exe files (#125)

* Bump Version
@denelon
Copy link
Contributor Author

denelon commented Mar 31, 2022

We are looking to start with a maximum of 8 manifests per PR. We will need to track all of the individual validations, and report on any that fail. All manifests and packages must pass validation to be merged in.

@SomeAspy
Copy link
Contributor

SomeAspy commented Oct 19, 2024

We are looking to start with a maximum of 8 manifests per PR. We will need to track all of the individual validations, and report on any that fail. All manifests and packages must pass validation to be merged in.

I entirely missed the plan to increment in binary progression. I completely agree with the plan here.

Perhaps a way to remove all versions of a single package would be nice - I just had to make about 20 PRs to completely remove my app from the winget store. While this would only be 3 PRs with your new limit, its still a bit messy. Otherwise, I pretty much agree with everything else

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants