Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rust-up-init-1.21.1 #1103

Closed
wants to merge 8 commits into from
Closed

add rust-up-init-1.21.1 #1103

wants to merge 8 commits into from

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented May 26, 2020

add rust-up-init-1.21.1 (7832b2ebe 2019-12-20) (latest version)

a convenient setup tool for rust toolchain

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 26, 2020
@ghost ghost assigned denelon May 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

This submission has moved to manual review.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 26, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

CGQAQ The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

CGQAQ The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label May 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

CGQAQ The package manager bot determined there was an issue with the pull request. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname.
For details on the error, see the details link below in the build pipeline.

@KevinLaMS
Copy link
Contributor

I cannot get this to install. The client is giving error 1.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jun 24, 2020

I cannot get this to install. The client is giving error 1.

@KevinLaMS I think its a bug

image

because I manually downloaded it from the URL inside YAML file, it installed perfectly

@ghost ghost removed the Needs: author feedback label Jun 24, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed the Validation-Error General Error during testing. Requires we provide comment to author. label Jun 24, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Jun 24, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

CGQAQ The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@wingetbot wingetbot removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs: author feedback labels Jun 24, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 24, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

This submission has moved to manual review.

@KevinLaMS
Copy link
Contributor

Interesting. Seems to be blocking on missing VC as part of install. So there is a dependency that is missing.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jun 24, 2020

Interesting. Seems to be blocking on missing VC as part of install. So there is a dependency that is missing.

@KevinLaMS Is there a verbose mode for winget install or something like that?
image
I think I will create another issue to point out this issue

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 22, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

This PR is a bit old 😄

I'm not sure if we still need support for dependencies or just to configure the result "1" as a success error code (if that is a success).

In either case, the manifest schema needs to be updated.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this May 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants