Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version: Sigil-Ebook.Sigil version 2.1.0 #147284

Merged
merged 4 commits into from
Apr 3, 2024
Merged

New Version: Sigil-Ebook.Sigil version 2.1.0 #147284

merged 4 commits into from
Apr 3, 2024

Conversation

dougmassay
Copy link
Contributor

@dougmassay dougmassay commented Apr 2, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 2, 2024
@dougmassay
Copy link
Contributor Author

I need just a little more to go on than "issue with installing the application" nothing has changed regarding the installer. It works fine everywhere I've tried it.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 2, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-04-01 18:03:47.191 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA4CC1C11F: (caller: 00007FFA4C9A8D6F) LogHr(1) tid(1cf8) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA4CB22B08: (caller: 00007FFA4CBCBC20) Exception(1) tid(1cf8) 8A15005E ]
2024-04-01 18:03:47.191 [REPO] Failed to open available source: msstore
2024-04-01 18:03:54.851 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA31D3C11F: (caller: 00007FFA31AC8D6F) LogHr(1) tid(67c) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA31C42B08: (caller: 00007FFA31CEBC20) Exception(1) tid(67c) 8A15005E ]
2024-04-01 18:03:54.851 [REPO] Failed to open available source: msstore
2024-04-01 18:03:56.122 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 876.)

@dougmassay
Copy link
Contributor Author

So it can't install the latest Microsoft.VCRedist.2015+.x64 dependency via it's winget manifest? I'm unaware of anything I can do to affect how that particular dependency gets installed. I've named the dependency correctly in my installer yaml. Surely I don't need to specify an exact version of the VCRedist.2015+.x64 package?

@dougmassay
Copy link
Contributor Author

Please advise. I'm seeing this error all over the place here. I can't fix a broken VCRedist.2015+.x64 dependency install by pushing more changes to my branch.

@dougmassay
Copy link
Contributor Author

#147337

@Trenly
Copy link
Contributor

Trenly commented Apr 2, 2024

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 2, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 2, 2024
@dougmassay
Copy link
Contributor Author

As mentioned previously, there is nothing for me to "fix." something has changed RE dependency packages that is breaking the Azure Pipeline.

See #147337

No ability to see any detailed logs referenced above - #147284 (comment) - concerning the error.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 2, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Apr 2, 2024

Automatic Validation ended with:

2024-04-02 05:05:18.989 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFEE493C11F: (caller: 00007FFEE46C8D6F) LogHr(1) tid(1780) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFEE4842B08: (caller: 00007FFEE48EBC20) Exception(1) tid(1780) 8A15005E ]
2024-04-02 05:05:18.989 [REPO] Failed to open available source: msstore
2024-04-02 05:05:26.148 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFECC74C11F: (caller: 00007FFECC4D8D6F) LogHr(1) tid(18d4) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFECC652B08: (caller: 00007FFECC6FBC20) Exception(1) tid(18d4) 8A15005E ]
2024-04-02 05:05:26.148 [REPO] Failed to open available source: msstore
2024-04-02 05:05:27.423 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 876.)

Edit:

2024-04-02 05:05:27.422 [CLI ] Installer [X64,burn,Machine,] not applicable: Installer scope does not match required scope: Machine != User
2024-04-02 05:05:27.423 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

The issue seems to be a scope mismatch. I believe the dependency only has machine scope, which is conflicting with the user scope here.

@dougmassay
Copy link
Contributor Author

The issue seems to be a scope mismatch. I believe the dependency only has machine scope, which is conflicting with the user scope here.

There was never a scope mismatch in the past. My yaml hasn't really changed (other than urls, shas, and version numbers) in a long time. If the dependency has changed their scope options, I'm at a loss as to how my package can possibly be installed with the user scope anymore.

I'd rather not have to assume the necessary vc++ redist libraries are already installed by removing the dependency from my installer yaml altogether.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Changes-Requested Changes Requested New-Manifest Manifest-Metadata-Consistency Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. labels Apr 2, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 2, 2024
Remove Dependencies property from root of manifest to eliminate a scope mismatch on vcredist dependency. Not an ideal workaround, but I'm tired.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Apr 2, 2024
@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 2, 2024
@wingetbot
Copy link
Collaborator

=== manifests\s\Sigil-Ebook\Sigil\2.1.0 ===
Missing Properties value based on version 2.0.2:
Dependencies

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit be715af into microsoft:master Apr 3, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 3, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants