Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata/Add Scope: namazso.OpenHashTab version v3.0.1 #21601

Merged
2 commits merged into from
Jul 17, 2021
Merged

Update metadata/Add Scope: namazso.OpenHashTab version v3.0.1 #21601

2 commits merged into from
Jul 17, 2021

Conversation

quhxl
Copy link
Contributor

@quhxl quhxl commented Jul 17, 2021 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Needs: Attention label Jul 17, 2021
@ghost ghost assigned ChuckFerring-zz Jul 17, 2021
@quhxl
Copy link
Contributor Author

quhxl commented Jul 17, 2021

@palenshus Can you take a look?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 17, 2021
@quhxl
Copy link
Contributor Author

quhxl commented Jul 17, 2021

It again installs fine on my x86 machine but doesn't pass the pipline...

@ghost ghost added Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed labels Jul 17, 2021
@ghost
Copy link

ghost commented Jul 17, 2021

Hello @msftbot[bot]!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 05793a0 into microsoft:master Jul 17, 2021
@quhxl quhxl deleted the Update-metadata/Add-Scope-namazso.OpenHashTab-version-v3.0.1 branch July 17, 2021 21:02
@OfficialEsco
Copy link
Contributor

This was a weird error tho as it got Validation-Executable-Error and Validation-No-Executables, but yeah i don't trust the x86 VM as it fails a lot

@djdv djdv mentioned this pull request Jul 18, 2021
Closed
@quhxl
Copy link
Contributor Author

quhxl commented Aug 2, 2021

@OfficialEsco I just stumbled across this. I am assuming that the "v" in the version name does not make this version show as the newest. Is there anything we can do about this? or is this to be related to the way the CLI works?

Screenshot 2021-08-02 123112

@OfficialEsco
Copy link
Contributor

I've seen this before, i believe there is a issue on winget-cli about it, is the older version actually 2.3.0 or v2.3.0?

@quhxl
Copy link
Contributor Author

quhxl commented Aug 2, 2021 •
edited
Loading

I've seen this before, i believe there is a issue on winget-cli about it, is the older version actually 2.3.0 or v2.3.0?

It is actually 2.3.0...

Screenshot 2021-08-02 123429

@OfficialEsco
Copy link
Contributor

ouch that sucks, i guess we can cheese it by naming it v2.3.0 if its the only version?
or wait for schema v1.1.0

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialEsco OfficialEsco OfficialEsco approved these changes

Assignees

@ChuckFerring-zz ChuckFerring-zz

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quhxl @wingetbot @OfficialEsco @ChuckFerring-zz