Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finebits 8 Zip app added #620

Closed
wants to merge 10 commits into from
Closed

Finebits 8 Zip app added #620

wants to merge 10 commits into from

Conversation

ValeraFinebits
Copy link
Contributor

@ValeraFinebits ValeraFinebits commented May 21, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 21, 2020
@ghost ghost assigned denelon May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 22, 2020
@KevinLaMS
Copy link
Contributor

Greetings. This package fails because it is dependent on some frameworks, and we do not support the dependencies yet. microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass. Thanks.

@ValeraFinebits
Copy link
Contributor Author

Looks like I can't add Microsoft.Services.Store.Engagement

MakeAppx : error: Error info: error 80080204: The package with file name "Microsoft.Services.Store.Engagement_10.0.19011.0_arm__8wekyb3d8bbwe.appx" and package full name "Microsoft.Services.Store.Engagement_10.0.19011.0_arm__8wekyb3d8bbwe" is not valid in the bundle because it's a framework package.
MakeAppx : error: Bundle creation failed.

@ghost ghost removed the Needs: author feedback label May 23, 2020
@KevinLaMS KevinLaMS added the Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled. label May 26, 2020
@ValeraFinebits
Copy link
Contributor Author

Maybe now we can approve and merge this request?

@denelon
Copy link
Contributor

denelon commented May 4, 2021

This PR is a bit old 😄

The schema needs to be updated.

@ghost ghost added Needs: Attention and removed Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. labels May 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 4, 2021
@ghost ghost removed the Manifest-Validation-Error Manifest validation failed label May 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

@ValeraFinebits The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels May 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

@ValeraFinebits The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost assigned arjun-msft May 4, 2021
@ValeraFinebits
Copy link
Contributor Author

This PR is a bit old 😄

The schema needs to be updated.

Done

@denelon
Copy link
Contributor

denelon commented May 4, 2021

@ValeraFinebits thank you for taking the time to update the manifest. I've contacted one of the engineering team members to see what caused the validation failure.

@arjun-msft arjun-msft added the Blocking-Issue Manifest validation is blocked by a known issue. label May 20, 2021
@denelon
Copy link
Contributor

denelon commented May 20, 2021

microsoft/winget-cli#163

@tiziodcaio
Copy link
Contributor

Maybe use this when will it be relased?

@arjun-msft arjun-msft removed their assignment Jun 8, 2021
@Trenly
Copy link
Contributor

Trenly commented Jan 14, 2022

@denelon Package is now available with winget install 9wzdncrfjb33 and this PR can be closed

@denelon
Copy link
Contributor

denelon commented Jan 14, 2022

@ValeraFinebits do you want us to keep this PR open?

@ValeraFinebits ValeraFinebits deleted the 8zipapp branch January 14, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@denelon denelon

Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ValeraFinebits @wingetbot @KevinLaMS @denelon @tiziodcaio @Trenly @arjun-msft @finebits-github