Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improvements to working patterns and flexibility index #160

Merged
merged 10 commits into from
Jul 2, 2021

Conversation

martinctc
Copy link
Member

@martinctc martinctc commented Jun 17, 2021

Summary

This branch addresses some feature and documentation requests for both workpatterns_classify() and flex_index().

Changes

The changes made in this PR are:

  1. Reintroduce old visual of heatmap distribution of activity across hours of the day (Feature request: reintroduce and improve 'old' workpatterns_classify() visual #143).
  2. Replaced colours of heatmap distribution visual from red to #1d627e (Feature request: reintroduce and improve 'old' workpatterns_classify() visual #143)
  3. Update wording to reflect the recurring nature of breaks (Documentation: refer to 'breaks' as 'recurring disconnection time' for working patterns #158)
  4. Added ability to run percentages for identify_shifts_wp() (Feature request: show % for identify_shifts_wp() #155)

Examples

image
image

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

Notes

This fixes #143, #155, #158.

@martinctc martinctc marked this pull request as ready for review June 30, 2021 09:04
@martinctc martinctc requested a review from moralec June 30, 2021 13:42
@martinctc martinctc linked an issue Jun 30, 2021 that may be closed by this pull request
@martinctc martinctc merged commit 1aadbc7 into main Jul 2, 2021
@martinctc martinctc deleted the feature/improve-working-patterns branch July 2, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant