Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve functional test diagnostics #161

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Improve functional test diagnostics #161

merged 2 commits into from
Feb 24, 2023

Conversation

mtfriesen
Copy link
Contributor

@mtfriesen mtfriesen commented Feb 24, 2023 •
edited
Loading

We're still seeing some flakiness in functional tests, generally in tests that are doing a bunch of packet IO.

Add two major new diagnostic points:

  1. Write test failure messages to ETW/WPP trace files, giving us single source of truth.
  2. Log all NBLs sent/received by functional MP and LWF.

@mtfriesen mtfriesen requested a review from a team as a code owner February 24, 2023 20:38
@mtfriesen mtfriesen merged commit 1bbe9c7 into main Feb 24, 2023
@mtfriesen mtfriesen deleted the mtfriesen/functional_diagnostics branch February 24, 2023 21:52
@mtfriesen mtfriesen mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csujedihy csujedihy csujedihy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtfriesen @csujedihy