Fix fnio filter for multi MDL NB #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a TX NB containing multiple MDLs is filtered, we would expect the resulting frame to either 1) Contain a single data buffer with all bytes of all MDLs or 2) Contain a data buffer per MDL In the case of a 2-MDL NB where the first MDL's ByteCount > NB data length, we end up with a single data buffer containing just the bytes of the first MDL. Fix this so that we consistently end up with option 2 above.
mtfriesen
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TX NB containing multiple MDLs is filtered, we would expect the resulting frame to either
In the case of a 2-MDL NB where the first MDL's ByteCount > NB data length, we end up with a single data buffer containing just the bytes of the first MDL.
Fix this so that we consistently end up with option 2 above.