Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Surface documentation links #2219

Merged
merged 51 commits into from
Apr 26, 2023
Merged

Feature: Surface documentation links #2219

merged 51 commits into from
Apr 26, 2023

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Nov 9, 2022 •
edited
Loading

Overview

Walks through the sample queries and resource explorer to get documentation links for the URL on the Query Input.

When available, changes the more info icon to be a documentation icon that allows a user to open the related link in a new tab

Closes #1854

Testing Instructions

  • Type in a URL
  • Notice that the icon changes from disabled to enabled
  • Click on the documentation icon
  • A tooltip opens with the statement that documentation is available for the URL
  • Click learn more and see the documentation on a new tab

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@thewahome thewahome changed the title Feature: documentation-links Feature: Surface documentation links Nov 9, 2022
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

1.2% 1.2% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

Onokaev
Onokaev reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Onokaev Onokaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the method labels are no longer there. Was this intentional?
image

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@Onokaev Onokaev self-requested a review April 26, 2023 07:58
Onokaev
Onokaev previously approved these changes Apr 26, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2219.centralus.azurestaticapps.net

@thewahome thewahome merged commit bf9bcd1 into dev Apr 26, 2023
16 of 17 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome deleted the feature/documentation-links branch May 3, 2023 07:16
adhiambovivian pushed a commit that referenced this pull request Jun 13, 2023
@ElinorW @Onokaev @thewahome
Chore: Release 9.0.0 (#2619)
38c60bb 
* Chore: Update to 8.2.0 (#2520)

* Fix: Add retry handler for revoking permissions (#2515)

* Fix: Modify permissions tab resize (#2523)

* Feature: Surface documentation links (#2219)

* Task: Add support for persisting collections (#2525)

* Chore: popups manager (#2514)

* Task: support multiple collections (#2549)

* Task: Show feedback - add to collections (#2555)

* Chore: change "remove" aria label (#2558)

* Chore: append unique paths to collection (#2560)

* Fix: Collections reducer failing test logic (#2573)

* Task: Reorder revoking permission event messages (#2526)

* Fix: Persist sample body (#2550)

* Fix: collection status for nodes with IDs (#2575)

* add tests

* get url for id nodes

* Chore: Update failing snapshots (#2571)

* Chore: Uppercase methods (#2578)

* Task: Dependabot upgrades for May (#2557)

* Task: Add support for uploading postman collections (#2579)

* Fix: Remove use of external label (#2582)

* Chore: utilise resource paths (#2584)

* Chore: ensure unique paths (#2586)

* Chore: Dependabot upgrades - June (#2612)

* Chore: Clear network error message (#2615)

* Task: Add new permissions scopeType (#2585)

* Bump version to 9.0.0

---------

Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
thewahome added a commit that referenced this pull request Mar 15, 2024
@thewahome @ElinorW @Onokaev
Chore: update to 9.7.0 (#3044)
419725c 
* Bump version to 8.1.0

* return playwright test branch condition

* Fix: Missing return statement (#2507)

* Bump version to 8.2.0

* Chore: Release 9.0.0 (#2619)

* Chore: Update to 8.2.0 (#2520)

* Fix: Add retry handler for revoking permissions (#2515)

* Fix: Modify permissions tab resize (#2523)

* Feature: Surface documentation links (#2219)

* Task: Add support for persisting collections (#2525)

* Chore: popups manager (#2514)

* Task: support multiple collections (#2549)

* Task: Show feedback - add to collections (#2555)

* Chore: change "remove" aria label (#2558)

* Chore: append unique paths to collection (#2560)

* Fix: Collections reducer failing test logic (#2573)

* Task: Reorder revoking permission event messages (#2526)

* Fix: Persist sample body (#2550)

* Fix: collection status for nodes with IDs (#2575)

* add tests

* get url for id nodes

* Chore: Update failing snapshots (#2571)

* Chore: Uppercase methods (#2578)

* Task: Dependabot upgrades for May (#2557)

* Task: Add support for uploading postman collections (#2579)

* Fix: Remove use of external label (#2582)

* Chore: utilise resource paths (#2584)

* Chore: ensure unique paths (#2586)

* Chore: Dependabot upgrades - June (#2612)

* Chore: Clear network error message (#2615)

* Task: Add new permissions scopeType (#2585)

* Bump version to 9.0.0

---------

Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

* Fix: Show documentation URL for supported Resource Explorer items (#2625)

* Fix: Ensure collections are initiated in store (#2627)

* Chore: Release 9.1.0 (#2694)

* Create microsoft-graph-explorer-v4-branch-protection.yml (#2617)

* Fix: Update dependencies with high security risk (#2631)

* Fix: Get documentation on resource render (#2634)

* Feature: Add flighting support (#2621)

* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669)

* Fix: Permissions scrollbar (#2576)

* Fix: Bundle Monaco-editor package (#2677)

* Fix: July Dependabot upgrades (#2679)

* Fix: Update resource management bot (#2682)

* Fix: Restore resources search box functionality (#2686)

* Bump version to 9.1.0

* Bump version to 9.2.0

* Bump version to 9.3.0

* Fix: Remove component chunking (#2871)

Temporarily removed until we have it working properly

* Chore: Hotfix release 9.3.2 (#2898)

* Hotfix: Upgrade msal-browser version (#2900)

* Bump version to 9.4.0

* add CI:false

* Chore: Release 9.5.0 (#2994)

* Chore: Update to 9.4.0 (#2959)

* Fix: Remove lazy loading on feedback button  (#2963)

* Fix: Ignore aria rule on Sample Queries component (#2962)

* Chore: change workflow permissions (#2966)

* Bump version to 9.5.0

---------

Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>

* Bump version to 9.6.0

* reset permissions to initial state on error

* fix failing tests

* Bump version to 9.7.0

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: Elinor <elkaguon@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW left review comments

@Onokaev Onokaev Onokaev left review comments

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@ddyett ddyett Awaiting requested review from ddyett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surface documentation about a URL in the query bar [Auto-Complete] Hide the 'more info' button
3 participants
@thewahome @ElinorW @Onokaev