-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: popups manager #2514
Chore: popups manager #2514
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Yes @ElinorW ... the button moved to where Fluent Defines Dialog Footer buttons to go. I didn't see there being a need to move it |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Not exactly. I chose to use the DialogFooter on the Panel and the Dialog components. And it sat right for both without changing anything. So it just made sense to leave it there |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
The Modify permissions tab and permissions panel reload every time a consent/unconsent action is performed. The same behavior is not in dev |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
Kudos, SonarCloud Quality Gate passed! |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net |
* Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
* Bump version to 8.1.0 * return playwright test branch condition * Fix: Missing return statement (#2507) * Bump version to 8.2.0 * Chore: Release 9.0.0 (#2619) * Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * Fix: Show documentation URL for supported Resource Explorer items (#2625) * Fix: Ensure collections are initiated in store (#2627) * Chore: Release 9.1.0 (#2694) * Create microsoft-graph-explorer-v4-branch-protection.yml (#2617) * Fix: Update dependencies with high security risk (#2631) * Fix: Get documentation on resource render (#2634) * Feature: Add flighting support (#2621) * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669) * Fix: Permissions scrollbar (#2576) * Fix: Bundle Monaco-editor package (#2677) * Fix: July Dependabot upgrades (#2679) * Fix: Update resource management bot (#2682) * Fix: Restore resources search box functionality (#2686) * Bump version to 9.1.0 * Bump version to 9.2.0 * Bump version to 9.3.0 * Fix: Remove component chunking (#2871) Temporarily removed until we have it working properly * Chore: Hotfix release 9.3.2 (#2898) * Hotfix: Upgrade msal-browser version (#2900) * Bump version to 9.4.0 * add CI:false * Chore: Release 9.5.0 (#2994) * Chore: Update to 9.4.0 (#2959) * Fix: Remove lazy loading on feedback button (#2963) * Fix: Ignore aria rule on Sample Queries component (#2962) * Chore: change workflow permissions (#2966) * Bump version to 9.5.0 --------- Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * Bump version to 9.6.0 * reset permissions to initial state on error * fix failing tests * Bump version to 9.7.0 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Elinor <elkaguon@microsoft.com>
Overview
Closes #2452
Demo
In the component that you want to load another component as a dialog / modal / panel, simply:
import it using the usePopups hook
const { open: openPermissions } = usePopups('full-permissions', 'panel');
Then call it by passing in parameters
Notes
Parameters in the functions are autocompleted e.g the component name and the type of display. The width in the settings