Task: Reorder revoking permission event messages #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2526.centralus.azurestaticapps.net |
thewahome
previously approved these changes
May 2, 2023
thewahome
reviewed
May 15, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2526.centralus.azurestaticapps.net |
thewahome
approved these changes
May 15, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
adhiambovivian
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
thewahome
added a commit
that referenced
this pull request
Mar 15, 2024
* Bump version to 8.1.0 * return playwright test branch condition * Fix: Missing return statement (#2507) * Bump version to 8.2.0 * Chore: Release 9.0.0 (#2619) * Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * Fix: Show documentation URL for supported Resource Explorer items (#2625) * Fix: Ensure collections are initiated in store (#2627) * Chore: Release 9.1.0 (#2694) * Create microsoft-graph-explorer-v4-branch-protection.yml (#2617) * Fix: Update dependencies with high security risk (#2631) * Fix: Get documentation on resource render (#2634) * Feature: Add flighting support (#2621) * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669) * Fix: Permissions scrollbar (#2576) * Fix: Bundle Monaco-editor package (#2677) * Fix: July Dependabot upgrades (#2679) * Fix: Update resource management bot (#2682) * Fix: Restore resources search box functionality (#2686) * Bump version to 9.1.0 * Bump version to 9.2.0 * Bump version to 9.3.0 * Fix: Remove component chunking (#2871) Temporarily removed until we have it working properly * Chore: Hotfix release 9.3.2 (#2898) * Hotfix: Upgrade msal-browser version (#2900) * Bump version to 9.4.0 * add CI:false * Chore: Release 9.5.0 (#2994) * Chore: Update to 9.4.0 (#2959) * Fix: Remove lazy loading on feedback button (#2963) * Fix: Ignore aria rule on Sample Queries component (#2962) * Chore: change workflow permissions (#2966) * Bump version to 9.5.0 --------- Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * Bump version to 9.6.0 * reset permissions to initial state on error * fix failing tests * Bump version to 9.7.0 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Elinor <elkaguon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This task reorders revoking permission events
Demo
Optional. Screenshots,
curlexamples, etc.Notes
The revoking permission initialization takes some time as there are a couple of async calls to get tenant information and permission grants.
This PR reorders the events so that they are dispatched before the initialization process begins.
Testing Instructions
Sign in with an AAD account
Consent to any permission
Click on Unconsent
Notice that the event messages are displayed much faster