Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add flighting support #2621

Merged
merged 28 commits into from
Jun 29, 2023
Merged

Feature: Add flighting support #2621

merged 28 commits into from
Jun 29, 2023

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Jun 12, 2023 •
edited
Loading

Overview

Closes #1569

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

Option 1

  • Open the staging link provided on different browsers.
  • Click on 'Resources' tab
  • Observe if icons are present or only display on hover
  • If you can produce both results on two different browsers then it's working

Option 2

  • Open the staging link
  • Open your browser 'Network' tab in developer tools
  • look for the 'tas' network call
  • Confirm it has a 200 status code and the response looks sth like this
    image

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@ElinorW ElinorW marked this pull request as ready for review June 16, 2023 13:09
@ElinorW ElinorW requested a review from a team as a code owner June 16, 2023 13:09
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

Onokaev
Onokaev requested changes Jun 20, 2023
View reviewed changes
src/app/services/variantService.ts Outdated Show resolved Hide resolved
@ElinorW @thewahome
Update local storage function
4499e48 
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

Onokaev
Onokaev previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Onokaev Onokaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@ElinorW ElinorW added the status:on-hold An issue/PR that we are yet to work on and can't make a decision on when to move forward label Jun 22, 2023
@ElinorW ElinorW dismissed stale reviews from thewahome and Onokaev via 6063483 June 22, 2023 15:44
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@ElinorW ElinorW removed the status:on-hold An issue/PR that we are yet to work on and can't make a decision on when to move forward label Jun 26, 2023
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2621.centralus.azurestaticapps.net

@Onokaev Onokaev self-requested a review June 29, 2023 11:02
@ElinorW ElinorW merged commit 0aed99f into dev Jun 29, 2023
17 of 18 checks passed
ElinorW added a commit that referenced this pull request Jul 27, 2023
@ElinorW
Chore: Release 9.1.0 (#2694)
3c1c9de 
* Create microsoft-graph-explorer-v4-branch-protection.yml (#2617)

* Fix: Update dependencies with high security risk (#2631)

* Fix: Get documentation on resource render (#2634)

* Feature: Add flighting support (#2621)

* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669)

* Fix: Permissions scrollbar (#2576)

* Fix: Bundle Monaco-editor package (#2677)

* Fix: July Dependabot upgrades (#2679)

* Fix: Update resource management bot (#2682)

* Fix: Restore resources search box functionality (#2686)

* Bump version to 9.1.0
@thewahome thewahome deleted the feature/feature-flags-demo branch September 27, 2023 12:18
thewahome added a commit that referenced this pull request Mar 15, 2024
@thewahome @ElinorW @Onokaev
Chore: update to 9.7.0 (#3044)
419725c 
* Bump version to 8.1.0

* return playwright test branch condition

* Fix: Missing return statement (#2507)

* Bump version to 8.2.0

* Chore: Release 9.0.0 (#2619)

* Chore: Update to 8.2.0 (#2520)

* Fix: Add retry handler for revoking permissions (#2515)

* Fix: Modify permissions tab resize (#2523)

* Feature: Surface documentation links (#2219)

* Task: Add support for persisting collections (#2525)

* Chore: popups manager (#2514)

* Task: support multiple collections (#2549)

* Task: Show feedback - add to collections (#2555)

* Chore: change "remove" aria label (#2558)

* Chore: append unique paths to collection (#2560)

* Fix: Collections reducer failing test logic (#2573)

* Task: Reorder revoking permission event messages (#2526)

* Fix: Persist sample body (#2550)

* Fix: collection status for nodes with IDs (#2575)

* add tests

* get url for id nodes

* Chore: Update failing snapshots (#2571)

* Chore: Uppercase methods (#2578)

* Task: Dependabot upgrades for May (#2557)

* Task: Add support for uploading postman collections (#2579)

* Fix: Remove use of external label (#2582)

* Chore: utilise resource paths (#2584)

* Chore: ensure unique paths (#2586)

* Chore: Dependabot upgrades - June (#2612)

* Chore: Clear network error message (#2615)

* Task: Add new permissions scopeType (#2585)

* Bump version to 9.0.0

---------

Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

* Fix: Show documentation URL for supported Resource Explorer items (#2625)

* Fix: Ensure collections are initiated in store (#2627)

* Chore: Release 9.1.0 (#2694)

* Create microsoft-graph-explorer-v4-branch-protection.yml (#2617)

* Fix: Update dependencies with high security risk (#2631)

* Fix: Get documentation on resource render (#2634)

* Feature: Add flighting support (#2621)

* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669)

* Fix: Permissions scrollbar (#2576)

* Fix: Bundle Monaco-editor package (#2677)

* Fix: July Dependabot upgrades (#2679)

* Fix: Update resource management bot (#2682)

* Fix: Restore resources search box functionality (#2686)

* Bump version to 9.1.0

* Bump version to 9.2.0

* Bump version to 9.3.0

* Fix: Remove component chunking (#2871)

Temporarily removed until we have it working properly

* Chore: Hotfix release 9.3.2 (#2898)

* Hotfix: Upgrade msal-browser version (#2900)

* Bump version to 9.4.0

* add CI:false

* Chore: Release 9.5.0 (#2994)

* Chore: Update to 9.4.0 (#2959)

* Fix: Remove lazy loading on feedback button  (#2963)

* Fix: Ignore aria rule on Sample Queries component (#2962)

* Chore: change workflow permissions (#2966)

* Bump version to 9.5.0

---------

Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>

* Bump version to 9.6.0

* reset permissions to initial state on error

* fix failing tests

* Bump version to 9.7.0

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: EvansA <evansonoka05.j@gmail.com>
Co-authored-by: Elinor <elkaguon@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onokaev Onokaev Onokaev approved these changes

@thewahome thewahome Awaiting requested review from thewahome

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for feature flags
3 participants
@ElinorW @Onokaev @thewahome