Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: use redux toolkit #3186

Merged
merged 98 commits into from
Aug 7, 2024
Merged

Task: use redux toolkit #3186

merged 98 commits into from
Aug 7, 2024

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Jun 3, 2024 •
edited
Loading

Overview

It's increasingly going to get harder to keep redux upto date without breaking changes. Redux Toolkit (RTK) is recommended by the Redux team as it simplifies Redux development. It provides utilities for creating and managing Redux stores, actions, and reducers.

Using this package will lead to uninstalling redux, and redux-thunk as RTK simplifies the import process by providing these functionalities under one package. Uninstalling means a few dependencies we do not need to manage

Fixes #3007
Closes #3211
Closes #3208

Testing Instructions

  • Load the app
  • Perform any and all operations and confirm their success

@thewahome thewahome requested a review from a team as a code owner June 3, 2024 15:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

musale
musale reviewed Jun 10, 2024
View reviewed changes
src/store/index.ts Outdated Show resolved Hide resolved
musale
musale reviewed Jun 10, 2024
View reviewed changes
src/store/index.ts Outdated Show resolved Hide resolved
musale
musale reviewed Jun 10, 2024
View reviewed changes
src/store/index.ts Outdated Show resolved Hide resolved
musale
musale reviewed Jun 10, 2024
View reviewed changes
src/store/index.ts Outdated Show resolved Hide resolved
@musale
Use createSlice for theme changing
9bc9e1d 
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@thewahome
remove manually written application state
c9766f0 
Uses the inferred one from state definition
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

musale
musale previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 good to go!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3186.centralus.azurestaticapps.net

musale
musale approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo!!

@thewahome thewahome merged commit b366636 into dev Aug 7, 2024
19 of 20 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@thewahome thewahome mentioned this pull request Aug 7, 2024
Closed
@thewahome thewahome deleted the task/use-redux-toolkit branch August 19, 2024 09:25
@thewahome thewahome mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musale musale musale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@thewahome @musale @Mnickii