-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgt.dev - changed monaco editor to light theme #350
Conversation
Good catch, I agree. Fixed |
Looks like that was a bug from before - can you check if the latest commit fixes that issue for you? |
It's still happening for me with the latest commits. Let me know if you want me to fiddle with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't repro the white space... that looks interesting though. Some small picks commented.
It's odd that I'm seeing the stale issue and @beth-panx is not. @vogtn, can you try this out and see if the whitespace issue repros for you? |
Sorry @shweaver-MSFT I can't seem to repro on my machines/screens :( |
@vogtn, I'm glad you can't repro it lol. I think I'm an outlier. I'll try cloning a fresh instance and see if it helps. But don't hold the PR back on my account. |
@shweaver-MSFT, have you been able to repro the issue on a fresh clone? |
@nmetulev, I still see the issue in Edge, but not in Chrome. If you don't see the issue in your Edge, than I assume it's an issue with my version of Edge. I can't get localhost to work at all in Edge dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in Chrome.
@nmetulev The latest fixed everything for me :) Good to go |
PR Type
Description of the changes
This PR updates the monaco editor used in mgt.dev to use the light theme. By request from: microsoftgraph/microsoft-graph-explorer-v4#452
It also increase the debounce time to 1s (from 0.5s) as I've found the 0.5s to be too fast when editing samples.