-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadlock in async code #52
Comments
Thank you for bringing this to our attention. I'll take a look at this. By the way, you should be able to update to the latest Nuget package. Nuget's default behavior is to use the earliest version of dependencies. Since you already have 6.0.2 installed, I expect that Nuget will keep that dependency if you update. Let us know if it behaves any differently. |
Under what circumstances did you encounter the deadlock? What call were you making? |
This is not the real code, but will give you an idea on how its being used: public async Task GetCurrentUser() All this is used in a controller of a MVC3 website (ASP.NET synchronizationContext) |
@atorresGit What exactly is the change that you'd like to get in BaseRequest.cs? I see the missing ConfigureAwait, but what else do you want to add in there? I believe that commit d41633daf8710e51bb320c3dd74e34b80dc9de06 correlates to version 1.0.1. Does this make sense to you as a watermark to tag? |
…false) to line 132, per https://msdn.microsoft.com/en-us/magazine/jj991977.aspx -- this should fix the deadlock,
Fixed with 837cd1f |
In BaseRequest class, SendAsync method, around line 132, when the response its being read, should be calling configureAwait(false).
We are using the library in a website with legacy sync code and we are having a deadlock because of this. Please can you put a tag in the code, signaling version 1.0.1, so we can fork that code and fix this in our solution. We can't use the latest version, because we need to keep using json.net 6.0.2.
I tried to create a pull request, but I don't have permissions.
Thanks!
The text was updated successfully, but these errors were encountered: