Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.1.0 #33

Merged
merged 3 commits into from
Oct 6, 2017
Merged

v3.1.0 #33

merged 3 commits into from
Oct 6, 2017

Conversation

microsoftly
Copy link
Owner

No description provided.

@microsoftly
Add message filter and in-line options update (#28)
519f235 
* added ability to filter messages

* added in line options modifier
@microsoftly
add builtin message filters to options/config (#30)
ab04000
@microsoftly
v3.1.0 (#32)
a4c07bd 
* add builtin message filters

* bump version for v3.1.0

* updated docs for publish
@microsoftly microsoftly merged commit d0b78df into master Oct 6, 2017
@microsoftly microsoftly deleted the dev branch October 6, 2017 02:03
@microsoftly microsoftly restored the dev branch October 6, 2017 02:04
@microsoftly microsoftly mentioned this pull request Oct 6, 2017
Closed
@microsoftly
Copy link
Owner Author

@bilby91 @santiagodoldan

@santiagodoldan
Copy link
Contributor

@microsoftly, I will need to try this code, but what happens if next week I want to filter messages of type foo globally, I will need to ask you to add a new pre-built filter? That doesn't seem flexible IMO. The addMessageFilter is great as I already said in my other PR, but it forces me to use it on each spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microsoftly @santiagodoldan