Refactor to use the uuidtools gem and add callback override option #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2014 15:49
(which doesn't work with Ruby 1.9.3). Add configuration option to specify which callback to use to set the GUID field (currently defaulted to :before_create to match documentation and ActiveRecord::Base behavior).
|
I like it. However, before I merge, please remove the version increment as I would like to be able to do that just before the release as a separate commit. I will increment the version to 1.2 as this is a small breaking change for some people and not a bug fix. |
|
Version number has been reverted. I also found a bug caused by the fact that our id field is replaced with a string GUID but with the same name. Because of that, we need to see if the current id is zero, null or an empty string. The ||= doesn't cover all those cases but .blank? properly does. |
|
Is there anything else you'd like done before you merge in my pull request? I'd like to change back to bundling this gem from the standard locations instead of having to point to my own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use the uuidtools gem instead of an ancient uuidtools.rb
(which doesn't work with Ruby 1.9.3).
Add configuration option to specify which callback to use to set the
GUID field (currently defaulted to :before_create to match documentation
and ActiveRecord::Base behavior).