STYLE: refs #257. Adding a style test and fixing the results.

Author: cpatrick

modules/api/library/APIEnabledNotification.php

@@ -21,7 +21,7 @@ class ApiEnabled_Notification extends MIDAS_Notification
    * This function is for getting the webapi methods defined in the API
    * component of the implementing class. To enable this add the following
    * line to your init function.
-   * 
+   *
    * $this->enableWebAPI();
    *
    */
@@ -30,34 +30,34 @@ public function getWebApiMethods()
     $methods = array();
     $r = new ReflectionClass($this->ModuleComponent->Api);
     $meths = $r->getMethods(ReflectionMethod::IS_PUBLIC);
-    foreach( $meths as $m )
+    foreach($meths as $m)
       {
-      if(strpos($m->getDeclaringClass()->getName(),'ApiComponent'))
+      if(strpos($m->getDeclaringClass()->getName(), 'ApiComponent'))
         {
         $realName = $m->getName();
         $docString = $m->getDocComment();
-        $docString = trim($docString,'/');
-        $docAttributes = explode('@',$docString);
+        $docString = trim($docString, '/');
+        $docAttributes = explode('@', $docString);
         $return = '';
         $description = '';
         $params = array();
         $example = array();
-        foreach( $docAttributes as $docEntry )
+        foreach($docAttributes as $docEntry)
           {
-          $explodedDoc = explode('*',$docEntry);
+          $explodedDoc = explode('*', $docEntry);
           array_walk($explodedDoc,
                      create_function('&$val', '$val = trim($val);'));
-          $doc = implode('',$explodedDoc);
-          if(strpos($doc,'param') === 0)
+          $doc = implode('', $explodedDoc);
+          if(strpos($doc, 'param') === 0)
             {
-            $splitParam = explode(' ',$doc);
+            $splitParam = explode(' ', $doc);
             $paramName = trim($splitParam[1]);
-            $paramValue = trim(implode(' ',array_slice($splitParam,2)));
+            $paramValue = trim(implode(' ', array_slice($splitParam, 2)));
             $params[$paramName] = $paramValue;
             }
-          elseif(strpos($doc,'return') === 0)
+          elseif(strpos($doc, 'return') === 0)
             {
-            $return = trim(substr($doc,6));
+            $return = trim(substr($doc, 6));
             }
           else
             {
@@ -70,7 +70,7 @@ public function getWebApiMethods()
         $help['example'] = $example;
         $help['return'] = $return;
         $help['description'] = $description;
-        $methods[] = array('name'=> $name,
+        $methods[] = array('name' => $name,
                            'help' => $help,
                            'callbackObject' => &$this->ModuleComponent->Api,
                            'callbackFunction' => $realName);

modules/api/tests/CMakeLists.txt

@@ -5,4 +5,6 @@ add_subdirectory( models )
 add_midas_style_test( StyleApiControllers ${CMAKE_SOURCE_DIR}/modules/api/controllers )
 add_midas_style_test( StyleApiModels ${CMAKE_SOURCE_DIR}/modules/api/models )
 add_midas_style_test( StyleTestsApiControllers ${CMAKE_SOURCE_DIR}/modules/api/tests/controllers )
-add_midas_style_test( StyleTestsApiModels ${CMAKE_SOURCE_DIR}/modules/api/tests/models )
+add_midas_style_test( StyleTestsApiModels ${CMAKE_SOURCE_DIR}/modules/api/tests/models )
+add_midas_style_test(StyleApiEnabledNotification
+${CMAKE_SOURCE_DIR}/modules/api/library/APIEnabledNotification.php)