Check that items have at least one revision where necessary

Jamie Snape · Jamie Snape · commit 220ea632d638 · 2015-05-12T18:19:43.000-04:00
diff --git a/core/controllers/ItemController.php b/core/controllers/ItemController.php
@@ -68,6 +68,9 @@ public function editmetadataAction()
         } else {
             $metadataItemRevision = $this->Item->getLastRevision($itemDao);
         }
+        if ($metadataItemRevision === false) {
+            throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+        }
         $metadatavalues = $this->ItemRevision->getMetadata($metadataItemRevision);
         $this->view->metadata = null;
 
@@ -121,6 +124,9 @@ public function viewAction()
             } else {
                 $metadataItemRevision = $itemRevision;
             }
+            if ($metadataItemRevision === false) {
+                throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+            }
             $deleteMetadata = $this->getParam('deleteMetadata');
             $editMetadata = $this->getParam('editMetadata');
             if (isset($deleteMetadata) && !empty($deleteMetadata) && $this->view->isModerator) { // delete metadata field
@@ -603,6 +609,9 @@ public function getmetadatavalueexistsAction()
             } else {
                 $metadataItemRevision = $this->Item->getLastRevision($itemDao);
             }
+            if ($metadataItemRevision === false) {
+                throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+            }
             $metadataDao->setItemrevisionId($metadataItemRevision->getKey());
             if ($this->Metadata->getMetadataValueExists($metadataDao)) {
                 $exists = 1;
diff --git a/core/controllers/ShareController.php b/core/controllers/ShareController.php
@@ -301,11 +301,13 @@ public function linksAction()
             case 'folder':
                 $dao = $this->Folder->load($id);
                 $name = $dao->getName().'.zip';
+                $hasDownload = true;
                 break;
             case 'item':
                 $dao = $this->Item->load($id);
-                $headRev = $this->Item->getLastRevision($dao);
                 $name = $dao->getName();
+                $headRev = $this->Item->getLastRevision($dao);
+                $hasDownload = $headRev !== false;
                 if (count($headRev->getBitstreams()) > 1) {
                     $name .= '.zip';
                 }
@@ -318,6 +320,10 @@ public function linksAction()
         $this->view->type = $type;
         $this->view->id = $id;
         $this->view->viewUrl = $baseUrl.'/'.$type.'/'.$id;
-        $this->view->downloadUrl = $baseUrl.'/download/'.$type.'/'.$id.'/'.urlencode($name);
+        if ($hasDownload === false) {
+            $this->view->downloadUrl = '';
+        } else {
+            $this->view->downloadUrl = $baseUrl.'/download/'.$type.'/'.$id.'/'.urlencode($name);
+        }
     }
 }
diff --git a/core/controllers/UploadController.php b/core/controllers/UploadController.php
@@ -113,10 +113,10 @@ public function revisionAction()
 
         // Check if the revision exists and if it does, we send its license ID to
         // the view. If it does not exist we use our default license
-        if ($itemRevision) {
-            $this->view->selectedLicense = $itemRevision->getLicenseId();
-        } else {
+        if ($itemRevision === false) {
             $this->view->selectedLicense = Zend_Registry::get('configGlobal')->defaultlicense;
+        } else {
+            $this->view->selectedLicense = $itemRevision->getLicenseId();
         }
 
         $this->view->allLicenses = $this->License->getAll();
diff --git a/core/controllers/components/ApihelperComponent.php b/core/controllers/components/ApihelperComponent.php
@@ -116,7 +116,7 @@ public function getItemRevision($item, $revisionNumber = null)
             if ($revisionDao) {
                 return $revisionDao;
             } else {
-                throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);
+                throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
             }
         }
 
@@ -129,7 +129,7 @@ public function getItemRevision($item, $revisionNumber = null)
         }
         $revisions = $item->getRevisions();
         if (count($revisions) === 0) {
-            throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);
+            throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
         }
         // check revisions exist
         foreach ($revisions as $revision) {
@@ -231,7 +231,7 @@ public function setMetadata($item, $type, $element, $qualifier, $value, $revisio
 
         // If no module handles this metadata, we add it as normal metadata on the item revision
         if (!$revisionDao) {
-            throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);
+            throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
         }
 
         /** @var MetadataModel $metadataModel */
diff --git a/core/controllers/components/ApiitemComponent.php b/core/controllers/components/ApiitemComponent.php
@@ -265,7 +265,7 @@ public function itemDeletemetadataAll($args)
         ) {
             $revisions = $item->getRevisions();
             if (count($revisions) === 0) {
-                throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);
+                throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
             }
             foreach ($revisions as $revisionDao) {
                 $itemRevisionModel->deleteMetadata($revisionDao);
diff --git a/core/controllers/components/ApisystemComponent.php b/core/controllers/components/ApisystemComponent.php
@@ -398,7 +398,7 @@ public function uploadGeneratetoken($args)
                 ) {
                     $revision = $itemModel->getLastRevision($item);
 
-                    if ($revision == false) {
+                    if ($revision === false) {
                         // Create new revision if none exists yet
                         Zend_Loader::loadClass('ItemRevisionDao', BASE_PATH.'/core/models/dao');
                         $revision = new ItemRevisionDao();
diff --git a/core/controllers/components/ExportComponent.php b/core/controllers/components/ExportComponent.php
@@ -109,18 +109,20 @@ public function exportBitstreams($userDao, $targetDir, $itemIds, $shouldSymLink)
                 }
                 // Use the given revision_number if it is not empty
                 if (isset($tmpId[1])) {
-                    $revisionNum = $itemModel->getRevision($item, $tmpId[1]);
-                    if ($revisionNum !== false) {
-                        $revisions[] = $revisionNum;
+                    $revision = $itemModel->getRevision($item, $tmpId[1]);
+                    if ($revision !== false) {
+                        $revisions[] = $revision;
                     } else {
                         throw new Zend_Exception(
                             "Revision number ".$tmpId[1]." for item ".$tmpId[0]." does not exist. Please check your input."
                         );
                     }
                 } else {
                     // Otherwise use the latest revision
-                    $revisionNum = $itemModel->getLastRevision($item);
-                    $revisions[] = $revisionNum;
+                    $revision = $itemModel->getLastRevision($item);
+                    if ($revision !== false) {
+                        $revisions[] = $revision;
+                    }
                 }
             }
         }
diff --git a/core/models/base/MetadataModelBase.php b/core/models/base/MetadataModelBase.php
@@ -122,7 +122,9 @@ public function addMetadataValue(
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel('Item');
         $lastrevision = $itemModel->getLastRevision($item);
-
+        if ($lastrevision === false) {
+            throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+        }
         // refresh zend search index if latest revision has changed
         if ($lastrevision->getKey() == $itemRevisionDao->getKey()) {
             $itemModel->save($item, $passItemMetadataChanged);
diff --git a/core/models/pdo/FolderModel.php b/core/models/pdo/FolderModel.php
@@ -1351,7 +1351,7 @@ public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunc
             $item = $this->initDao('Item', $row);
             $rev = $this->Item->getLastRevision($item);
 
-            if (!$rev) {
+            if ($rev === false) {
                 $zip->addFile($path.'/'.$item->getName(), ''); // add empty item
                 continue;
             }
diff --git a/core/models/pdo/ItemRevisionModel.php b/core/models/pdo/ItemRevisionModel.php
@@ -95,6 +95,9 @@ public function deleteMetadata($revisiondao, $metadataId = null)
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel('Item');
         $lastrevision = $itemModel->getLastRevision($item);
+        if ($lastrevision === false) {
+            throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+        }
 
         // refresh lucene search index
         if ($lastrevision->getKey() == $revisiondao->getKey()) {
diff --git a/modules/batchmake/controllers/components/ExecuteComponent.php b/modules/batchmake/controllers/components/ExecuteComponent.php
@@ -62,9 +62,12 @@ public function exportSingleBitstreamItemsToWorkDataDir($userDao, $taskDao, $ite
         foreach ($itemsForExport as $itemName => $itemId) {
             $itemDao = $itemModel->load($itemId);
             $revisionDao = $itemModel->getLastRevision($itemDao);
+            if ($revisionDao === false) {
+                throw new Zend_Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+            }
             $bitstreamDaos = $revisionDao->getBitstreams();
             if (empty($bitstreamDaos)) {
-                throw new Zend_Exception("Item ".$itemId." had no bitstreams.");
+                throw new Zend_Exception("Item ".$itemId." has no bitstreams.");
             }
             $imageBitstreamDao = $bitstreamDaos[0];
             $exportedBitstreamPath = $datapath.'/'.$itemId.'/'.$imageBitstreamDao->getName();
diff --git a/modules/dicomextractor/controllers/components/ApiitemComponent.php b/modules/dicomextractor/controllers/components/ApiitemComponent.php
@@ -53,6 +53,9 @@ public function extract($args)
         }
 
         $revisionDao = $itemModel->getLastRevision($itemDao);
+        if ($revisionDao === false) {
+            throw new Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+        }
 
         /** @var Dicomextractor_ExtractorComponent $dicomComponent */
         $dicomComponent = MidasLoader::loadComponent('Extractor', 'dicomextractor');
diff --git a/modules/dicomextractor/controllers/components/ExtractorComponent.php b/modules/dicomextractor/controllers/components/ExtractorComponent.php
@@ -153,6 +153,10 @@ public function thumbnail($item)
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel("Item");
         $revision = $itemModel->getLastRevision($item);
+        if ($revision === false) {
+            return;
+        }
+
         $bitstreams = $revision->getBitstreams();
         $numBitstreams = count($bitstreams);
         if ($numBitstreams < 1) {
diff --git a/modules/dicomserver/controllers/components/ApiserverComponent.php b/modules/dicomserver/controllers/components/ApiserverComponent.php
@@ -350,6 +350,9 @@ public function register($args)
         }
 
         $revisionDao = $itemModel->getLastRevision($itemDao);
+        if ($revisionDao === false) {
+            throw new Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+        }
 
         /** @var Dicomserver_ServerComponent $dicomComponent */
         $dicomComponent = MidasLoader::loadComponent('Server', 'dicomserver');
diff --git a/modules/oai/library/oai/listrecords.php b/modules/oai/library/oai/listrecords.php
@@ -199,6 +199,9 @@
     $output .= '   </header>'."\n";
 
     $revision = $itemModel->getLastRevision($element);
+    if ($revision === false) {
+        throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+    }
     $metadata = $itemRevisionModel->getMetadata($revision);
     include BASE_PATH.'/modules/oai/library/oai/'.$inc_record;
 
diff --git a/modules/packages/controllers/components/ApiComponent.php b/modules/packages/controllers/components/ApiComponent.php
@@ -104,7 +104,13 @@ public function extensionList($args)
 
         foreach ($daos as $dao) {
             $revision = $itemModel->getLastRevision($dao->getItem());
+            if ($revision === false) {
+                continue;
+            }
             $bitstreams = $revision->getBitstreams();
+            if (count($bitstreams) === 0) {
+                continue;
+            }
             $bitstream = $bitstreams[0];
 
             $results[] = array(
@@ -231,6 +237,9 @@ public function extensionUpload($args)
             /** @var ItemRevisionModel $itemRevisionModel */
             $itemRevisionModel = MidasLoader::loadModel('ItemRevision');
             $itemRevision = $itemModel->getLastRevision($item);
+            if ($itemRevision === false) {
+                throw new Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+            }
             $itemRevision->setChanges($args['revision']);
             $itemRevisionModel->save($itemRevision);
 
@@ -317,6 +326,9 @@ public function packageList($args)
         $results = array();
         foreach ($daos as $dao) {
             $revision = $itemModel->getLastRevision($dao->getItem());
+            if ($revision === false) {
+                continue;
+            }
             $bitstreams = $revision->getBitstreams();
             $bitstreamsArray = array();
             foreach ($bitstreams as $bitstream) {
diff --git a/modules/pvw/controllers/components/ParaviewComponent.php b/modules/pvw/controllers/components/ParaviewComponent.php
@@ -242,14 +242,26 @@ private function _createDataDir($itemDao, $meshItems, $instanceDao)
         /** @var ItemRevisionModel $revisionModel */
         $revisionModel = MidasLoader::loadModel('ItemRevision');
         $rev = $itemModel->getLastRevision($itemDao);
+        if ($rev === false) {
+            throw new Zend_Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+        }
         $bitstreams = $rev->getBitstreams();
+        if (count($bitstreams) === 0) {
+            throw new Zend_Exception('The item has no bitstreams', MIDAS_INVALID_POLICY);
+        }
         $src = $bitstreams[0]->getFullpath();
         symlink($src, $path.'/main/'.$bitstreams[0]->getName());
 
         // Symlink all the surfaces into the surfaces subdir
         foreach ($meshItems as $meshItem) {
             $rev = $itemModel->getLastRevision($meshItem);
+            if ($rev === false) {
+                continue;
+            }
             $bitstreams = $rev->getBitstreams();
+            if (count($bitstreams) === 0) {
+                continue;
+            }
             $src = $bitstreams[0]->getFullpath();
             $linkPath = $path.'/surfaces/'.$meshItem->getKey().'_'.$bitstreams[0]->getName();
             symlink($src, $linkPath);
diff --git a/modules/pvw/controllers/components/ValidationComponent.php b/modules/pvw/controllers/components/ValidationComponent.php
@@ -43,11 +43,11 @@ private function _testItem($itemDao, $extensions)
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel('Item');
         $revision = $itemModel->getLastRevision($itemDao);
-        if (empty($revision)) {
+        if ($revision === false) {
             return false;
         }
         $bitstreams = $revision->getBitstreams();
-        if (count($bitstreams) == 0) {
+        if (count($bitstreams) === 0) {
             return false;
         }
 
diff --git a/modules/readmes/controllers/components/GetReadmeComponent.php b/modules/readmes/controllers/components/GetReadmeComponent.php
@@ -44,7 +44,13 @@ public function fromFolder($folder)
             return array('text' => '');
         }
         $revisionDao = $itemModel->getLastRevision($readmeItem);
+        if ($revisionDao === false) {
+            return array('text' => '');
+        }
         $bitstreams = $revisionDao->getBitstreams();
+        if (count($bitstreams) === 0) {
+            return array('text' => '');
+        }
         $bitstream = $bitstreams[0];
         $path = $bitstream->getAssetstore()->getPath().'/'.$bitstream->getPath();
         $contents = file_get_contents($path);
diff --git a/modules/remoteprocessing/controllers/ExecutableController.php b/modules/remoteprocessing/controllers/ExecutableController.php
@@ -74,6 +74,9 @@ public function defineAction()
             file_put_contents($pathFile, $xmlContent);
 
             $revision = $this->Item->getLastRevision($itemDao);
+            if ($revision === false) {
+                throw new Zend_Exception('The item has no revisions', MIDAS_INVALID_POLICY);
+            }
             $bitstreams = $revision->getBitstreams();
 
             $itemRevisionDao = new ItemRevisionDao();
diff --git a/modules/remoteprocessing/controllers/JobController.php b/modules/remoteprocessing/controllers/JobController.php
@@ -257,8 +257,11 @@ public function viewAction()
             } elseif ($item->type == MIDAS_REMOTEPROCESSING_RELATION_TYPE_INPUT) {
                 $inputs[$item->getName()] = $item;
             } elseif ($item->type == MIDAS_REMOTEPROCESSING_RELATION_TYPE_OUPUT) {
-                $reviesion = $this->Item->getLastRevision($item);
-                $metadata = $this->ItemRevision->getMetadata($reviesion);
+                $revision = $this->Item->getLastRevision($item);
+                if ($revision === false) {
+                    throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+                }
+                $metadata = $this->ItemRevision->getMetadata($revision);
                 $item->metadata = $metadata;
 
                 foreach ($metadata as $m) {
@@ -271,11 +274,14 @@ public function viewAction()
 
                 $outputs[] = $item;
             } elseif ($item->type == MIDAS_REMOTEPROCESSING_RELATION_TYPE_RESULTS) {
-                $reviesion = $this->Item->getLastRevision($item);
-                $metadata = $this->ItemRevision->getMetadata($reviesion);
+                $revision = $this->Item->getLastRevision($item);
+                if ($revision === false) {
+                    throw new Zend_Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);
+                }
+                $metadata = $this->ItemRevision->getMetadata($revision);
                 $item->metadata = $metadata;
 
-                $bitstreams = $reviesion->getBitstreams();
+                $bitstreams = $revision->getBitstreams();
                 if (count($bitstreams) == 1) {
                     $log = file_get_contents($bitstreams[0]->getFullPath());
                 }
diff --git a/modules/remoteprocessing/controllers/components/ExecutableComponent.php b/modules/remoteprocessing/controllers/components/ExecutableComponent.php
@@ -32,6 +32,9 @@ public function getMetaIoFile($itemDao)
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel('Item');
         $revision = $itemModel->getLastRevision($itemDao);
+        if ($revision === false) {
+            return false;
+        }
         $bitstreams = $revision->getBitstreams();
         $metaFile = false;
         foreach ($bitstreams as $b) {
@@ -52,6 +55,9 @@ public function getExecutable($itemDao)
         /** @var ItemModel $itemModel */
         $itemModel = MidasLoader::loadModel('Item');
         $revision = $itemModel->getLastRevision($itemDao);
+        if ($revision === false) {
+            return false;
+        }
         $bitstreams = $revision->getBitstreams();
         foreach ($bitstreams as $b) {
             if (is_executable($b->getFullPath())) {
diff --git a/modules/solr/Notification.php b/modules/solr/Notification.php
@@ -87,7 +87,7 @@ public function indexItem($args)
 
             $revision = $this->Item->getLastRevision($item);
 
-            if ($revision != false) {
+            if ($revision !== false) {
                 $metadata = $this->ItemRevision->getMetadata($revision);
                 $metadataString = '';
 
diff --git a/modules/solr/controllers/components/ApisearchComponent.php b/modules/solr/controllers/components/ApisearchComponent.php
diff --git a/modules/thumbnailcreator/controllers/components/ApiitemComponent.php b/modules/thumbnailcreator/controllers/components/ApiitemComponent.php
diff --git a/modules/thumbnailcreator/controllers/components/ImagemagickComponent.php b/modules/thumbnailcreator/controllers/components/ImagemagickComponent.php
diff --git a/modules/visualize/controllers/ImageController.php b/modules/visualize/controllers/ImageController.php
diff --git a/modules/visualize/controllers/MediaController.php b/modules/visualize/controllers/MediaController.php
diff --git a/modules/visualize/controllers/ParaviewController.php b/modules/visualize/controllers/ParaviewController.php
diff --git a/modules/visualize/controllers/PdfController.php b/modules/visualize/controllers/PdfController.php
diff --git a/modules/visualize/controllers/TxtController.php b/modules/visualize/controllers/TxtController.php
diff --git a/modules/visualize/controllers/WebglController.php b/modules/visualize/controllers/WebglController.php
diff --git a/modules/visualize/controllers/components/MainComponent.php b/modules/visualize/controllers/components/MainComponent.php

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function getItemRevision($item, $revisionNumber = null)`
`116`	`116`	`if ($revisionDao) {`
`117`	`117`	`return $revisionDao;`
`118`	`118`	`} else {`
`119`		`- throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);`
	`119`	`+ throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
`@@ -129,7 +129,7 @@ public function getItemRevision($item, $revisionNumber = null)`
`129`	`129`	`}`
`130`	`130`	`$revisions = $item->getRevisions();`
`131`	`131`	`if (count($revisions) === 0) {`
`132`		`- throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);`
	`132`	`+ throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);`
`133`	`133`	`}`
`134`	`134`	`// check revisions exist`
`135`	`135`	`foreach ($revisions as $revision) {`
`@@ -231,7 +231,7 @@ public function setMetadata($item, $type, $element, $qualifier, $value, $revisio`
`231`	`231`
`232`	`232`	`// If no module handles this metadata, we add it as normal metadata on the item revision`
`233`	`233`	`if (!$revisionDao) {`
`234`		`- throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);`
	`234`	`+ throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`/** @var MetadataModel $metadataModel */`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ public function itemDeletemetadataAll($args)`
`265`	`265`	`) {`
`266`	`266`	`$revisions = $item->getRevisions();`
`267`	`267`	`if (count($revisions) === 0) {`
`268`		`- throw new Exception("The item must have at least one revision to have metadata.", MIDAS_INVALID_POLICY);`
	`268`	`+ throw new Exception('The item must have at least one revision to have metadata', MIDAS_INVALID_POLICY);`
`269`	`269`	`}`
`270`	`270`	`foreach ($revisions as $revisionDao) {`
`271`	`271`	`$itemRevisionModel->deleteMetadata($revisionDao);`
Original file line number	Diff line number	Diff line change
`@@ -109,18 +109,20 @@ public function exportBitstreams($userDao, $targetDir, $itemIds, $shouldSymLink)`
`109`	`109`	`}`
`110`	`110`	`// Use the given revision_number if it is not empty`
`111`	`111`	`if (isset($tmpId[1])) {`
`112`		`- $revisionNum = $itemModel->getRevision($item, $tmpId[1]);`
`113`		`- if ($revisionNum !== false) {`
`114`		`- $revisions[] = $revisionNum;`
	`112`	`+ $revision = $itemModel->getRevision($item, $tmpId[1]);`
	`113`	`+ if ($revision !== false) {`
	`114`	`+ $revisions[] = $revision;`
`115`	`115`	`} else {`
`116`	`116`	`throw new Zend_Exception(`
`117`	`117`	`"Revision number ".$tmpId[1]." for item ".$tmpId[0]." does not exist. Please check your input."`
`118`	`118`	`);`
`119`	`119`	`}`
`120`	`120`	`} else {`
`121`	`121`	`// Otherwise use the latest revision`
`122`		`- $revisionNum = $itemModel->getLastRevision($item);`
`123`		`- $revisions[] = $revisionNum;`
	`122`	`+ $revision = $itemModel->getLastRevision($item);`
	`123`	`+ if ($revision !== false) {`
	`124`	`+ $revisions[] = $revision;`
	`125`	`+ }`
`124`	`126`	`}`
`125`	`127`	`}`
`126`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1351,7 +1351,7 @@ public function zipStream(&$zip, $path, $folder, &$userDao, &$overrideOutputFunc`
`1351`	`1351`	`$item = $this->initDao('Item', $row);`
`1352`	`1352`	`$rev = $this->Item->getLastRevision($item);`
`1353`	`1353`
`1354`		`- if (!$rev) {`
	`1354`	`+ if ($rev === false) {`
`1355`	`1355`	`$zip->addFile($path.'/'.$item->getName(), ''); // add empty item`
`1356`	`1356`	`continue;`
`1357`	`1357`	`}`