ENH: Improved error notification process

Author: Charles Marion

core/AppController.php

@@ -52,9 +52,9 @@ public function preDispatch()
         }
       Zend_Session::start();  
       $user = new Zend_Session_Namespace('Auth_User');
+      $modelLoad = new MIDAS_ModelLoader();
       if($user->Dao == null)
-        {
-        $modelLoad = new MIDAS_ModelLoader();
+        {        
         $userModel = $modelLoad->loadModel('User');
         $cookieData = $this->getRequest()->getCookie('midasUtil');
         if(!empty($cookieData))
@@ -70,19 +70,39 @@ public function preDispatch()
             }
           }
         }
+        
+      if($fc->getRequest()->getControllerName() == 'browse')
+        {
+        session_write_close();
+        }
       $this->userSession = $user;
       $this->view->recentItems = array();
       $this->view->showUploadedLink = false;
+      $this->view->needUpgrade = false;
+      $this->view->highNumberError = false;
       if($user->Dao != null && $user->Dao instanceof UserDao)
         {
-        if($fc->getRequest()->getControllerName() != 'install' && $fc->getRequest()->getControllerName() != 'error' && $user->Dao->isAdmin() && $this->isUpgradeNeeded())
-          {
-          $this->view->needUpgrade = true;
-          }
-        else
-          {
-          $this->view->needUpgrade = false;
+        if($fc->getRequest()->getControllerName() != 'install' && $fc->getRequest()->getControllerName() != 'error' && $user->Dao->isAdmin())
+          {          
+          if($this->isUpgradeNeeded())
+            {
+            $this->view->needUpgrade = true;
+            }  
+          $errorlogModel = $modelLoad->loadModel('Errorlog');
+          $logs = $errorlogModel->getLog(date('c', strtotime("-24 hour")), date('c'), 'all', 'all');
+          foreach($logs as $key => $l)
+            {
+            if($l->getPriority() == MIDAS_PRIORITY_INFO)
+              {
+              unset($logs[$key]);
+              }
+            }
+          if(count($logs) > 5)
+            {
+            $this->view->highNumberError = true;
+            }
           }
+
 
         if(!empty($user->uploaded))
           {

core/configs/application.ini

@@ -13,10 +13,6 @@ application.lang=en
 smartoptimizer=1
 ;Session lifetime (minute)
 session.lifetime=20
-;alert e-mail
-alert.email=charles.marion@kitware.com
-;E-mail admin
-alert.enable=1
 ;Path to md5sum
 md5sum.path=
 ;Password prefix

core/constant/error.php

@@ -0,0 +1,5 @@
+<?php
+define("MIDAS_PRIORITY_INFO", 6);
+define("MIDAS_PRIORITY_CRITICAL", 2);
+define("MIDAS_PRIORITY_WARNING", 4);
+?>

core/controllers/ErrorController.php

@@ -111,6 +111,5 @@ private function _applicationError()
         $this->view->message = nl2br($fullMessage);  
       }  
 
-    $this->Component->NotifyError->notify();  
     }  
 }  

core/controllers/components/NotifyErrorComponent.php

@@ -69,7 +69,6 @@ public function fatalEror($logger, $mailer)
           echo $message;
           $this->_mailer = $mailer;
           $this->_environment = $environment;
-          //$this->notify(true);
           break;  
         default:  
           $this->_server = $_SERVER;
@@ -248,31 +247,4 @@ public function getShortErrorMessage()
     return $message;  
     }  
 
-  /** Send an email*/
-  public function notify($fatal = false)  
-    { 
-    if(!in_array($this->_environment, array('production')) && Zend_Registry::get('configGlobal')->alert->enable == '1') 
-      {  
-      return false;  
-      }  
-            
-    $this->_mailer->setFrom('do-not-reply@domain.com');  
-    $this->_mailer->setSubject("Exception on Application ".Zend_Registry::get('configGlobal')->application->name);  
-    if(!$fatal)
-      {
-      $this->_mailer->setBodyText($this->getFullErrorMessage()); 
-      }
-    $this->_mailer->addTo(Zend_Registry::get('configGlobal')->alert->email);  
-    $return = false;
-    try 
-      {
-      $return = $this->_mailer->send();
-      }
-    catch(Exception $e)
-      {
-      $this->getLogger()->crit($e->getMessage());
-      }         
-
-    return $return;  
-    }  
   }  

core/include.php

@@ -9,6 +9,7 @@
 
 //include constant files
 include_once BASE_PATH.'/core/constant/global.php';
+include_once BASE_PATH.'/core/constant/error.php';
 include_once BASE_PATH.'/core/constant/datatype.php';
 include_once BASE_PATH.'/core/constant/community.php';
 include_once BASE_PATH.'/core/constant/group.php';

core/layouts/layout.phtml

@@ -154,6 +154,10 @@
         {
         echo '<span style="color:red;">MIDAS need to be upgraded. <a href="'.$this->webroot.'/admin/#ui-tabs-1">Upgrade</a></span><br/><br/>';
         }
+      if($this->highNumberError)
+        {
+        echo '<span style="color:red;">More thant 5 errors occured during the last 24 hours. <a href="'.$this->webroot.'/admin/#ui-tabs-2">Cherck the logs</a></span><br/><br/>';
+        }
       ?>
       <div class=SubWrapper">