Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

Commit 967a26d

Browse files
author
Charles Marion
committed
BUG: fixed recent item cookie lenght issue
1 parent b8255a2 commit 967a26d

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

core/AppController.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,16 @@ public function preDispatch()
6767
// check if recent items exit (every 10 minutes)
6868
if(isset($check)||strtotime($user->Dao->lastAction)<strtotime("-1 minute"))
6969
{
70-
echo "yeah";exit;
7170
$modelLoad = new MIDAS_ModelLoader();
7271
$itemModel = $modelLoad->loadModel('Item');
7372
foreach ($this->view->recentItems as $key => $t)
7473
{
75-
$item=$itemModel->load($t->getKey());
74+
if(!is_array($t))
75+
{
76+
unset($this->view->recentItems[$key]);
77+
continue;
78+
}
79+
$item=$itemModel->load($t['item_id']);
7680
if($item==false)
7781
{
7882
unset($this->view->recentItems[$key]);

core/controllers/ItemController.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function viewAction()
5555
$i=0;
5656
foreach($tmp as $key=>$t)
5757
{
58-
if($t->getKey()==$itemDao->getKey())
58+
if($t['item_id']==$itemDao->getKey())
5959
{
6060
unset($tmp[$key]);
6161
continue;
@@ -67,7 +67,9 @@ function viewAction()
6767
}
6868
}
6969
$recentItems=array_reverse($tmp);
70-
$recentItems[]=$itemDao;
70+
$itemDaoArray['item_id']=$itemDao->getKey();
71+
$itemDaoArray['name']=$itemDao->getName();
72+
$recentItems[]=$itemDaoArray;
7173

7274
setcookie('recentItems'.$this->userSession->Dao->getKey(), serialize($recentItems), time()+60*60*24*30,'/'); //30 days
7375
}

core/layouts/layout.phtml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,10 @@
162162
echo '<ul>';
163163
foreach ($recentReverse as $item)
164164
{
165-
echo "<li onclick=\"location.replace('{$this->webroot}/item/{$item->getKey()}');\" class='recentItem' title='". str_replace("'", '"', $item->getName())." | todo'><a href='{$this->webroot}/item/{$item->getKey()}'>".sliceRecentItem($item->getName())."</a></li>";
165+
if(is_array($item))
166+
{
167+
echo "<li onclick=\"location.replace('{$this->webroot}/item/{$item['item_id']}');\" class='recentItem' title='". str_replace("'", '"', $item['name'])." | todo'><a href='{$this->webroot}/item/{$item['item_id']}'>".sliceRecentItem($item['name'])."</a></li>";
168+
}
166169
}
167170
echo '</ul>';
168171
}

0 commit comments

Comments
 (0)