ENH: refs #0284. Add a freaking awesome test for folder deletion

Author: zachmullen

core/tests/models/base/FolderModelTest.php

@@ -121,4 +121,109 @@ public function testAddItem()
     $items = $folder->getItems();
     $this->assertEquals(1, count($items));
     }
+
+  /**
+   * Make sure deleting a folder deletes its child items when they are
+   * unique to that folder.
+   */
+  public function testDeleteFolderDeletesItem()
+    {
+    $folder = $this->Folder->createFolder('TestFolder1', 'Description', 0);
+    $this->assertTrue($folder->saved);
+
+    $item = new ItemDao();
+    $item->setName('subItem');
+    $item->setDescription('test item to be deleted');
+    $item->setType(0);
+    $this->Item->save($item);
+    $this->assertTrue($item->saved);
+    $this->Folder->addItem($folder, $item);
+    $items = $folder->getItems();
+    $this->assertEquals(1, count($items));
+    $this->assertEquals($items[0]->getName(), 'subItem');
+    $folderid = $folder->getKey();
+    $itemid = $items[0]->getKey();
+
+    // Make sure item gets deleted when we delete its parent folder
+    $this->Folder->delete($folder, true);
+    $folder = $this->Folder->load($folderid);
+    $this->assertEquals(false, $folder);
+    $item = $this->Item->load($itemid);
+    $this->assertEquals(false, $item);
+    }
+
+  /**
+   * Make sure deleting a folder does not delete its child item if that
+   * item is contained in another folder.
+   */
+  public function testDeleteFolderDoesNotDeleteSharedItem()
+    {
+    $folder1 = $this->Folder->createFolder('TestFolder1', 'Description', 0);
+    $folder2 = $this->Folder->createFolder('TestFolder2', 'Description', 0);
+    $this->assertTrue($folder1->saved);
+    $this->assertTrue($folder2->saved);
+
+    $item = new ItemDao();
+    $item->setName('subItemShared');
+    $item->setDescription('test item');
+    $item->setType(0);
+    $this->Item->save($item);
+    $this->assertTrue($item->saved);
+    $this->Folder->addItem($folder1, $item);
+    $this->Folder->addItem($folder2, $item);
+    $items1 = $folder1->getItems();
+    $this->assertEquals(1, count($items1));
+    $this->assertEquals($items1[0]->getName(), 'subItemShared');
+    $items2 = $folder2->getItems();
+    $this->assertEquals(1, count($items2));
+    $this->assertEquals($items2[0]->getName(), 'subItemShared');
+    $folderid1 = $folder1->getKey();
+    $folderid2 = $folder2->getKey();
+    $itemid = $items2[0]->getKey();
+
+    // Make sure item was not deleted
+    $this->Folder->delete($folder1, true);
+    $folder = $this->Folder->load($folderid1);
+    $this->assertEquals(false, $folder);
+    $item = $this->Item->load($itemid);
+    $this->assertNotEquals(false, $item, 'Item should not have been deleted');
+
+    // Make sure item record still exists in 2nd folder
+    $folder2 = $this->Folder->load($folderid2);
+    $items = $folder2->getItems();
+    $this->assertEquals(1, count($items), 'Item record was deleted from second folder');
+    $this->assertEquals($items[0]->getName(), 'subItemShared');
+
+    // Delete second folder, make sure item is then deleted
+    $this->Folder->delete($folder2, true);
+    $item = $this->Item->load($itemid);
+    $this->assertEquals(false, $item, 'Item should have been deleted');
+    }
+
+  /**
+   * Test that calling removeItem from a folder deletes a non-shared item
+   */
+  public function testRemoveItemDeletesNonSharedItem()
+    {
+    $folder = $this->Folder->createFolder('TestFolder1', 'Description', 0);
+    $this->assertTrue($folder->saved);
+
+    $item = new ItemDao();
+    $item->setName('subItem');
+    $item->setDescription('test item to be deleted');
+    $item->setType(0);
+    $this->Item->save($item);
+    $this->assertTrue($item->saved);
+    $this->Folder->addItem($folder, $item);
+    $items = $folder->getItems();
+    $this->assertEquals(1, count($items));
+    $this->assertEquals($items[0]->getName(), 'subItem');
+    $folderid = $folder->getKey();
+    $itemid = $items[0]->getKey();
+
+    // Make sure item is deleted when it is removed from its only parent
+    $this->Folder->removeItem($folder, $item);
+    $item = $this->Item->load($itemid);
+    $this->assertEquals(false, $item, 'Item should have been deleted');
+    }
   }