Fixing style issues.

Author: cpatrick

modules/tracker/database/upgrade/1.2.0.php

@@ -30,31 +30,27 @@ class Tracker_Upgrade_1_2_0 extends MIDASUpgrade
     public function mysql()
     {
         $this->db->query("ALTER TABLE `tracker_scalar` ADD COLUMN `submission_id` bigint(20) NOT NULL DEFAULT '-1';");
-        $this->db->query(<<<EOD
-CREATE TABLE IF NOT EXISTS `tracker_submission` (
-    `submission_id` bigint(20) NOT NULL AUTO_INCREMENT,
-    `name` varchar(255) NOT NULL DEFAULT '',
-    `uuid` varchar(255) NOT NULL DEFAULT '',
-    `submit_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
-    PRIMARY KEY (`submission_id`),
-    KEY (`uuid`)
-) DEFAULT CHARSET=utf8;
-EOD
-        );
+        $this->db->query(
+            "CREATE TABLE IF NOT EXISTS `tracker_submission` (".
+            "    `submission_id` bigint(20) NOT NULL AUTO_INCREMENT,".
+            "    `name` varchar(255) NOT NULL DEFAULT '',".
+            "    `uuid` varchar(255) NOT NULL DEFAULT '',".
+            "    `submit_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,".
+            "    PRIMARY KEY (`submission_id`),".
+            "     KEY (`uuid`)".
+            ") DEFAULT CHARSET=utf8;");
     }
 
     /** Upgrade a PostgreSQL database. */
     public function pgsql()
     {
         $this->db->query("ALTER TABLE tracker_scalar ADD COLUMN submission_id bigint NOT NULL DEFAULT -1::bigint;");
-        $this->db->query(<<<EOD
-CREATE TABLE IF NOT EXISTS "tracker_submission" (
-    "submission_id" serial PRIMARY KEY,
-    "name" character varying(255) NOT NULL DEFAULT ''::character varying,
-    "uuid" character varying(255) NOT NULL DEFAULT ''::character varying,
-    "submit_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
-);
-EOD
+        $this->db->query(
+            'CREATE TABLE IF NOT EXISTS "tracker_submission" ('.
+            '    "submission_id" serial PRIMARY KEY,'.
+            '    "name" character varying(255) NOT NULL DEFAULT \'\'::character varying,'.
+            '    "uuid" character varying(255) NOT NULL DEFAULT \'\'::character varying,'.
+            '    "submit_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP);'
         );
         $this->db->query('CREATE INDEX "tracker_submission_uuid" ON "tracker_submission" ("uuid");');
         $this->db->query('CREATE INDEX "tracker_submission_submit_time" ON "tracker_submission" ("submit_time");');

modules/tracker/models/base/SubmissionModelBase.php

@@ -42,6 +42,9 @@ public function __construct()
         $this->initialize();
     }
 
+    /** Create a submssions given a uuid, userId, and a name. */
     public abstract function createSubmission($uuid, $userId, $name = '');
+
+    /** Get the scalars associated with a submission. */
     public abstract function getScalars($submissionDao, $userId);
 }