Revise communityagreement module to remove redundant configuration form

Author: Jamie Snape

modules/communityagreement/Notification.php

@@ -43,7 +43,7 @@ public function getCommunityManageTabs($args)
         $fc = Zend_Controller_Front::getInstance();
         $moduleWebroot = $fc->getBaseUrl().'/communityagreement';
 
-        return array('Agreement' => $moduleWebroot.'/config/agreementtab');
+        return array('Agreement' => $moduleWebroot.'/community/agreementtab');
     }
 
     /**
@@ -56,7 +56,7 @@ public function getCommunityViewJSs()
         $fc = Zend_Controller_Front::getInstance();
         $moduleUriroot = $fc->getBaseUrl().'/modules/communityagreement';
 
-        return array($moduleUriroot.'/public/js/config/config.agreementenforce.js');
+        return array($moduleUriroot.'/public/js/community/community.agreementenforce.js');
     }
 
     /**

modules/communityagreement/controllers/ConfigController.php renamed to modules/communityagreement/controllers/CommunityController.php

@@ -18,25 +18,12 @@
  limitations under the License.
 =========================================================================*/
 
-/**
- * Communityagreement_ConfigController
- *
- * @category   Midas modules
- * @package    communityagreement
- */
-class Communityagreement_ConfigController extends Communityagreement_AppController
+/** Community controller for the community agreement module. */
+class Communityagreement_CommunityController extends Communityagreement_AppController
 {
     public $_models = array('Community');
     public $_moduleModels = array('Agreement');
-    public $_moduleForms = array('Config');
-
-    /**
-     * @throws Zend_Exception on invalid userSession
-     */
-    public function indexAction()
-    {
-        $this->requireAdminPrivileges();
-    }
+    public $_moduleForms = array('Community');
 
     /** community agreement tab
      *
@@ -70,7 +57,7 @@ public function agreementtabAction()
             $agreementDao = $this->Communityagreement_Agreement->createAgreement($communityId, $agreement);
         }
 
-        $formAgreement = $this->ModuleForm->Config->createCreateAgreementForm($communityId);
+        $formAgreement = $this->ModuleForm->Community->createCreateAgreementForm($communityId);
         if ($this->_request->isPost() && $formAgreement->isValid($this->getRequest()->getPost())
         ) {
             $this->disableView();

modules/communityagreement/controllers/forms/ConfigForm.php renamed to modules/communityagreement/controllers/forms/CommunityForm.php

@@ -18,14 +18,8 @@
  limitations under the License.
 =========================================================================*/
 
-/**
- * Communityagreement_ConfigForm
- *
- * @category   Midas modules
- * @package    communityagreement
- * @copyright  Copyright (c) Kitware SAS. See Copyright.txt for details.
- */
-class Communityagreement_ConfigForm extends AppForm
+/** Community form for the communityagreement module. */
+class Communityagreement_CommunityForm extends AppForm
 {
     /**
      * Create create_agreement form
@@ -37,7 +31,7 @@ public function createCreateAgreementForm($community_id)
     {
         $form = new Zend_Form();
         $form->setAction(
-            $this->webroot.'/communityagreement/config/agreementtab?communityId='.$community_id
+            $this->webroot.'/communityagreement/community/agreementtab?communityId='.$community_id
         )->setMethod('post');
         $agreement = new Zend_Form_Element_Textarea('agreement');
 

modules/communityagreement/public/css/config/config.agreementdialog.css renamed to modules/communityagreement/public/css/community/community.agreementdialog.css

@@ -14,7 +14,7 @@ $(document).ready(function () {
 
     if (hasAgreement == 'true') {
         $('form#joinCommunityForm').unbind('submit').submit(function () {
-            midas.loadDialog('agreement', '/communityagreement/config/agreementdialog?communityId=' + json.community.community_id);
+            midas.loadDialog('agreement', '/communityagreement/community/agreementdialog?communityId=' + json.community.community_id);
             midas.showDialog('Community Agreement', false, {
                 width: 500
             });