BUG: fixed bug #151 Now always check if the item exits

Author: Charles Ma

core/AppController.php

@@ -152,29 +152,28 @@ public function preDispatch()
         $cookieData = $this->getRequest()->getCookie('recentItems'.$this->userSession->Dao->user_id);
         $this->view->recentItems = array();
         if(isset($cookieData) && file_exists(BASE_PATH.'/core/configs/database.local.ini')) //check if midas installed
-          {          
-          $this->view->recentItems = unserialize($cookieData); 
-          $check = $this->_getParam('checkRecentItem');
-          // check if recent items exit (every 5 minutes)
-          if(isset($check) || !isset($user->Dao->lastAction) || strtotime($user->Dao->lastAction) < strtotime("-5 minute"))
+          {  
+          $modelLoad = new MIDAS_ModelLoader();
+          $itemModel = $modelLoad->loadModel('Item');
+          $tmpRecentItems = unserialize($cookieData);
+          $recentItems = array();
+          if(!empty($tmpRecentItems) && is_array($tmpRecentItems))
             {
-            $modelLoad = new MIDAS_ModelLoader();
-            $itemModel = $modelLoad->loadModel('Item');
-            foreach($this->view->recentItems as $key => $t)
-              {
-              if(!is_array($t))
-                {
-                unset($this->view->recentItems[$key]);
-                continue;
-                }
-              $item = $itemModel->load($t['item_id']);
-              if($item == false)
-                {
-                unset($this->view->recentItems[$key]);
-                }
-              }
-            setcookie('recentItems'.$this->userSession->Dao->getKey(), serialize($this->view->recentItems), time() + 60 * 60 * 24 * 30, '/'); //30 days
+             foreach($tmpRecentItems as $key => $t)
+               {
+               if(is_numeric($t))
+                 {
+                 $item = $itemModel->load($t);
+                 if($item !== false)
+                   {
+                   $recentItems[] = $item->toArray();
+                   }
+                 }
+               }
             }
+
+          $this->view->recentItems = $recentItems; 
+          $check = $this->_getParam('checkRecentItem');
           } 
         $user->Dao->lastAction = date('c');
         }

core/controllers/ItemController.php

@@ -139,7 +139,7 @@ function viewAction()
       $i = 0;
       foreach($tmp as $key => $t)
         {
-        if($t['item_id'] == $itemDao->getKey())
+        if($t == $itemDao->getKey() || !is_numeric($t))
           {
           unset($tmp[$key]);
           continue;
@@ -151,9 +151,7 @@ function viewAction()
           }
         }
       $recentItems = array_reverse($tmp);
-      $itemDaoArray['item_id'] = $itemDao->getKey();
-      $itemDaoArray['name'] = $itemDao->getName();
-      $recentItems[] = $itemDaoArray;
+      $recentItems[] = $itemDao->getKey();
 
       setcookie('recentItems'.$this->userSession->Dao->getKey(), serialize($recentItems), time() + 60 * 60 * 24 * 30, '/'); //30 days
       }

core/layouts/layout.phtml

@@ -216,7 +216,7 @@ echo $this->doctype()
                 {
                 if(is_array($item))
                   {
-                  echo "<li onclick=\"location.replace('{$this->webroot}/item/{$item['item_id']}');\" class='recentItem' title='".  str_replace("'", '"', $item['name'])." | todo'><a  href='{$this->webroot}/item/{$item['item_id']}'>".$this->slicename($item['name'],20)."</a></li>";
+                  echo "<li onclick=\"location.replace('{$this->webroot}/item/{$item['item_id']}');\" class='recentItem' title='".  str_replace("'", '"', $item['name'])."'><a  href='{$this->webroot}/item/{$item['item_id']}'>".$this->slicename($item['name'],20)."</a></li>";
                   }                  
                 }
               echo '</ul>';