Escape variables in keyfiles module

Jamie Snape · Jamie Snape · commit c8c82e3c0b6c · 2014-12-08T09:20:01.000-05:00
diff --git a/modules/keyfiles/Notification.php b/modules/keyfiles/Notification.php
@@ -46,7 +46,7 @@ public function getItemMenuLink($params)
         }
         $webroot = Zend_Controller_Front::getInstance()->getBaseUrl();
 
-        return '<li><a href="'.$webroot.'/'.$this->moduleName.'/download/item?itemId='.$params['item']->getKey().
+        return '<li><a href="'.$webroot.'/'.$this->moduleName.'/download/item?itemId='.htmlspecialchars($params['item']->getKey(), ENT_QUOTES, 'UTF-8').
         '"><img alt="" src="'.$webroot.'/core/public/images/icons/key.png" /> Download key files</a></li>';
     }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function getItemMenuLink($params)`
`46`	`46`	`}`
`47`	`47`	`$webroot = Zend_Controller_Front::getInstance()->getBaseUrl();`
`48`	`48`
`49`		`- return '<li><a href="'.$webroot.'/'.$this->moduleName.'/download/item?itemId='.$params['item']->getKey().`
	`49`	`+ return '<li><a href="'.$webroot.'/'.$this->moduleName.'/download/item?itemId='.htmlspecialchars($params['item']->getKey(), ENT_QUOTES, 'UTF-8').`
`50`	`50`	`'"><img alt="" src="'.$webroot.'/core/public/images/icons/key.png" /> Download key files</a></li>';`
`51`	`51`	`}`
`52`	`52`