fix: fix typing on core middy handler #630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
With current Typescript definition it is not possible to locally execute the handler function, either from a local file to debug, or from unit tests, without getting a Typescript error:
I believe the issue is that the Typescript definition of the
MiddyfiedHandler
does not extend the Lambda Handler so is not a callable function.Fix is to add
LambdaHandler
to theMiddyfiedHandler
interface definition.Does this close any currently open issues?
closes #628
Any relevant logs, error output, etc?
Any other comments?
Looking for someone else to validate this fix. Since it is only typing, it does not affect core functionality.
Where has this been tested?
Node.js Versions: v14.15.5
Middy Versions: 2.0.0.beta.0
AWS SDK Versions: v2/v3
Todo list
[ ] Feature/Fix fully implemented
[ ] Added tests
[ ] Updated relevant documentation
[ ] Updated relevant examples