Wrong open dialog default directory [closes #4] #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midenok
force-pushed
the
i4
branch
2 times, most recently
from
34a401b
to
1c34899
Compare
We require at least 3.0 now anyway
Broke with 6ccc2a3 BUG: 386709 FIXED-IN: 5.2.1
Otherwise this might cause a crash when clicking on items in the navigation tooltips. BUG: 386901 FIXED-IN: 5.2.1
Summary: and as a result, fix standard msvc include directories not being provided to the language plugin. Reviewers: mwolff Subscribers: mwolff, kdevelop-devel Differential Revision: https://phabricator.kde.org/D8805
Summary: Rather than passing null device as input file to the compiler, "-" is passed as argument which makes the compiler take input from stdin, then qprocess' standard input file is set to QProcess:nullDevice() to make it read eof. Note that it fixes standard includes not being passed to language plugin if clang is set as default compiler under windows. Reviewers: #kdevelop, kfunk Reviewed By: #kdevelop, kfunk Subscribers: kfunk, brauch, kdevelop-devel Differential Revision: https://phabricator.kde.org/D8831
(cherry picked from commit c917ebbef90138de3dde2dea06cb3b8dcde0d4f8)
Otherwise this test later pops up a message box indicating that lldb-mi is not available anyhow.
With this change, .mo files are still installed (after one did `make fetch-translations`) BUG: 386946 FIXED-IN: 5.2.1
Otherwise this test later pops up a message box indicating that lldb-mi is not available anyhow.
Changes: - Make it a bit easier to contiously build docker image - More RUN lines (which are then cached if successful) - Bump versions - LLVM: 5.0.0 - Qt: 5.9.1
See https://bugs.llvm.org/show_bug.cgi?id=35333 for details and explanation. We need to do two things to work around this bug: disable -Wdocumentation, and only use the plain text from the comments instead of the parsed version. REVIEW: https://phabricator.kde.org/D8857 BUG: 358205 BUG: 372686 FIXED-IN: 5.2.1
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
QVERSION_SHORT -> QTVERSION_SHORT
Summary: Don't allow the project tree view widget to collapse. It confuses uses when they accidentally hide it. Also see discussion: https://phabricator.kde.org/D8217
BUG:386527 Differential Revision: https://phabricator.kde.org/D8872
BUG:386929 FIXED-IN:5.2.1
We used to only offer code completion of project paths for local code completion in `#include "..."` contexts. And for vice versa, we only offered system paths for global code completion in `#include <...>` contexts. This is wrong, as the include style only changes the order in which a compiler iterates through these paths to find an include file. For code completion purposes, this is not important. Now we offer code completion in both path lists always. To show the user the right file/dir being included, we don't sort and unify the search path list anymore as that potentially changes the final result. Rather, we use a hash set to ensure we don't encounter paths multiple times and iterate over the search path lists in their original order. BUG: 386421
Reviewers: #kdevelop, flherne, kfunk Reviewed By: #kdevelop, kfunk Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9778
(cherry picked from commit c2031c5dcdc5ab0d77e0935392103a30f606293c)
(cherry picked from commit d212fa1d09421045849f6f6d73161af7f72448f0)
Summary: For visibility purposes, all 'inclue file not found' errors are associated with all files in a TU, since these usually completely break the interpretation of a file. But in some situations, this triggers a severe performance degradation: When the TU has a deep include stack depth and a file is not found somewhere at the bottom of the stack, then it will have one child diagnostic for every "included from ..." file higher up in the stack. Now if we would repeatedly build and intern the KDevelop::Problem representation for these diagnostics, for every file in the TU, we sometimes ended up spending *minutes* to create all the problems in ParseSession::problemsForFile! To workaround this situation, cache the ProblemPointer in the ParseSessionData for a given translation unit. This way, we will only convert a given diagnostic and its child diagnostics once per TU instead of once per file contained in a TU. In my case this brings down the time spent in problemsForFile for a single TU from ~7min (sic!) down to ~12s. While the latter is still a lot, this is already much more bearable. BUG: 386720 Reviewers: #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9772
Summary: I just found a noticeable GUI hang when showing a problem widget for a missing include path. There, the profiler pointed me at KIconLoader which was reconstructed whenever we query for the icon representing the severity of a problem. By reusing the global icon loader, we can get the information from the cache which is significantly faster. Reviewers: #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9783
Differential Revision: https://phabricator.kde.org/D9858 (cherry picked from commit 71f7bed96dd0954635c2793c681ba8a5da9ba318)
Summary: a bug in kLineEdit causes spurious emission of textEdited signals when calling setText(). This in turn causes spurious calls of compilerEdited() when selecting a compiler in the compilers window, which leads to a segfault (e.g. this bug https://bugs.kde.org/show_bug.cgi?id=373004) and I think some duplicates also. I have submitted also a patch to kcompletion, https://phabricator.kde.org/D9808 This is a workaround for those systems until that is fixed Reviewers: #kdevelop, apol, mwolff Reviewed By: #kdevelop, mwolff Subscribers: mwolff, anthonyfieroni, kdevelop-devel Tags: #kdevelop Differential Revision: https://phabricator.kde.org/D9809 BUG: 373004 FIXED-IN: 5.2.2
Reviewers: #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9924 (cherry picked from commit a6093e7ed7b3dca83aaea25747ac9b8a5ffc85d7)
Summary: Someone changed the test clients without adapting the GDB printer tests... Reviewers: #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9923 (cherry picked from commit f4dd6425f3436fec1a75736d59812eb7ce2a5ebb)
Summary: By changing the test client back to what it expects. Blindly also adapt the LLDB test which introduced the regression in the first place. Note that I cannot run the LLDB test locally, so I'm not sure whether the test passes there. Still, don't break GDB tests, people are using those... Reviewers: #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9922 (cherry picked from commit eeb8c640deb51c016ffdcefe83fae11f218dfae3)
Summary: Sorry about breaking gdb printer tests. I must have forgotten adapting them when merging lldb and gdb tests. Anyway, this patch uses correct expected values in lldb tests. Reviewers: kfunk, #kdevelop Reviewed By: kfunk, #kdevelop Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9929 (cherry picked from commit 06298b24fee156bc4e482d470fc7b737f45ec709)
There's a behaviorial change in Qt, starting with qtbase.git commit f62768d046528636789f901ac79e2cfa1843a7b7 (included in Qt 5.9.3). See commit diff for details. (cherry picked from commit 8eb7bc717d3c96cac806851a7e6e80dfa3006594)
KProcess::execute(...) by default waits indefinitely. Set a timeout. (cherry picked from commit a485241c96e221f3844d96f35a94a37752be7d6b)
... and try to fix hang on CI...
Use enable_testing() to always create a CTestTestfile, and prune the test project after each test run to remove any stale files. (cherry picked from commit 8f265cca47f605aa0843433800df67a07fae4301)
Summary: The lib is not experimental anymore. Reviewers: #kdevelop, apol Subscribers: kdevelop-devel Differential Revision: https://phabricator.kde.org/D9921 (cherry picked from commit 831cf5f98d78ddf64655456cd84ff166d45141d8)
... without losing any information though. Also, instead of: Debugger state changed to: QFlags(0x2|0x100) "" We now get something like (for Qt >= v5.8.0): Debugger state changed to: QFlags<KDevMI::DBGStateFlag>(s_appNotStarted|s_dbgBusy) "" - changes: QFlags<KDevMI::DBGStateFlag>(s_none)
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4