shell out to cucumber-js #25
Conversation
| env: workerEnv, | ||
| silent: !this.options.inlineStream | ||
| }); | ||
| let cucumberPath = './node_modules/.bin/cucumber-js'; |
There was a problem hiding this comment.
you could also just run node . in node_modules/cucumber rather than having any windows logic.
There was a problem hiding this comment.
i don't think this actually works. cucumber.js in the module root isn't actually the module's CLI entry point.
| @@ -11,6 +11,7 @@ import options from './fixtures/options'; | |||
| describe('Test Handler', function() { | |||
| it('should wait for all children to exit before returning', function () { | |||
| var opts = options.default; | |||
| this.timeout(5000); | |||
There was a problem hiding this comment.
the default is 2 seconds, but on windows, starting cucumber-js is pretty slow and takes up to 3 or 4 seconds. (it's a test timeout, not a wait)
| return done(result); | ||
| }) | ||
| .catch(function(err) { | ||
| return done({ |
There was a problem hiding this comment.
This object looks duped from the reject in worker?
There was a problem hiding this comment.
So sometimes while I'm testing something in the worker breaks and throws an exception separately from the reject :-/
| this.workers.push(worker); | ||
|
|
||
| return worker.execute() | ||
| .then(function(result) { |
There was a problem hiding this comment.
These are the only two missed now I think
|
👍 |
@midniteio @efokschaner @vsiakka
This replaces the current fork + cucumber-js API approach with directly spawning a new process that shells out to cucumber-js. This way, if cucumber-js ends for any reason (crash, regular test failure, etc.) we'll still detect the process has exited and handle it properly.