Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regexp for root path match #2105

Merged
merged 10 commits into from
Jul 12, 2022
Merged

fix: regexp for root path match #2105

merged 10 commits into from
Jul 12, 2022

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Jul 10, 2022

  • 1、处理 path-to-regexp 新老版本的差异性,换成新版本之后支持 match 方法(ctx.params 使用)
  • 2、修复 filter 之前的 bug(好像之前没人发现)
  • 3、恢复 dev --entryFile 的支持(虽然用处不是很大)
  • 4、ssl 的功能在 mock 模块中支持(看看是不是不能在其他 web 场景用)

@gitpod-io
Copy link

gitpod-io bot commented Jul 10, 2022

@gitguardian
Copy link

gitguardian bot commented Jul 10, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #2105 (f5c50cb) into main (8e187c4) will increase coverage by 0.39%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
+ Coverage   81.89%   82.29%   +0.39%     
==========================================
  Files         426      426              
  Lines       14506    14717     +211     
  Branches     3413     3500      +87     
==========================================
+ Hits        11880    12111     +231     
+ Misses       2401     2384      -17     
+ Partials      225      222       -3     
Impacted Files Coverage Δ
packages/core/src/common/webGenerator.ts 7.14% <ø> (ø)
packages/core/src/service/slsFunctionService.ts 94.00% <ø> (ø)
packages/mock/src/client/rabbitMQ.ts 5.96% <ø> (ø)
packages/mock/src/creator.ts 67.56% <68.18%> (+0.71%) ⬆️
packages/mikro/src/configuration.ts 92.85% <84.61%> (-7.15%) ⬇️
packages/core/src/service/webRouterService.ts 94.02% <88.88%> (+0.41%) ⬆️
packages/core/src/util/index.ts 79.64% <100.00%> (ø)
packages/core/src/util/pathToRegexp.ts 100.00% <100.00%> (+27.43%) ⬆️
packages/faas/src/framework.ts 77.64% <100.00%> (+0.27%) ⬆️
packages/swagger/src/swaggerExplorer.ts 79.81% <0.00%> (-0.92%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e187c4...f5c50cb. Read the comment docs.

@czy88840616 czy88840616 merged commit 97ccc03 into main Jul 12, 2022
@czy88840616 czy88840616 deleted the fix_path_to_regexp branch July 12, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants