Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view-nunjucks): add autoescape config && add ts interface #2148

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

wakeGISer
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • fix view-nunjuck engine doesn't pass through parameter 'autoescape' into nunjucks engine config
  • add typescript interface for the view-nunjucks component default config

@gitpod-io
Copy link

gitpod-io bot commented Jul 23, 2022

@wakeGISer wakeGISer changed the title fix(engine): add autoescape config && add ts interface fix(view-nunjucks): add autoescape config && add ts interface Jul 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #2148 (3b3d0de) into main (d5db880) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   82.06%   81.93%   -0.13%     
==========================================
  Files         433      433              
  Lines       15138    15138              
  Branches     3577     3577              
==========================================
- Hits        12423    12404      -19     
- Misses       2481     2497      +16     
- Partials      234      237       +3     
Impacted Files Coverage Δ
...ackages/view-nunjucks/src/config/config.default.ts 100.00% <ø> (ø)
packages/view-nunjucks/src/engine.ts 100.00% <100.00%> (ø)
packages/oss/src/manager.ts 38.88% <0.00%> (-50.00%) ⬇️
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) ⬇️
packages/upload/src/parse.ts 93.70% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5db880...3b3d0de. Read the comment docs.

@czy88840616 czy88840616 merged commit 8d39739 into midwayjs:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants