Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boilerplate): update pkg.engines.node requirement #293

Merged
merged 4 commits into from
Jul 23, 2019

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Jul 23, 2019

Update pkg.engines.node requirement to >=10.13.0 (#279)

v10.13.0 become active LTS

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@waitingsong waitingsong force-pushed the boilerplate branch 3 times, most recently from b6a7033 to 323f4df Compare July 23, 2019 02:34
@waitingsong
Copy link
Member Author

另外,想说 antd 有点恐怖: client 下 npm i 之后依赖包有 600M……

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #293   +/-   ##
======================================
  Coverage    86.7%   86.7%           
======================================
  Files          35      35           
  Lines         692     692           
  Branches       47      47           
======================================
  Hits          600     600           
  Misses         82      82           
  Partials       10      10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4dcde...d84cde1. Read the comment docs.

@czy88840616
Copy link
Member

czy88840616 commented Jul 23, 2019

帮忙把所有的脚手架都改一下,下半年应该都会到 10 了。

@waitingsong
Copy link
Member Author

waitingsong commented Jul 23, 2019

node.js 都升级到 10.13 ?
下午来弄。

@czy88840616
Copy link
Member

最新的? 10.16

@czy88840616 czy88840616 self-requested a review July 23, 2019 03:51
@czy88840616
Copy link
Member

前端库都挺大的。。。

Update pkg.engines.node requirement to >=10.16.0  (midwayjs#279)
- ts-node to ^8.3.0
- typescript to ^3.5.0
@waitingsong
Copy link
Member Author

waitingsong commented Jul 23, 2019

所有模板更新:

  • engines.node requirement to >=10.16.0
  • ts-node to ^8.3.0
  • typescript to ^3.5.0

@waitingsong
Copy link
Member Author

waitingsong commented Jul 23, 2019

e73ae35 这个对于 tsconfig.json 参数值并无变化,删除条目的值既是默认值 (一个目的是让人不知道某些个参数 (^-^))。

@types/mocha to ^6.0.0 according to egg-bin
Copy link
Member

@czy88840616 czy88840616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦了。

@czy88840616 czy88840616 merged commit e830be7 into midwayjs:master Jul 23, 2019
@waitingsong waitingsong deleted the boilerplate branch July 23, 2019 10:33
czy88840616 pushed a commit that referenced this pull request Jul 23, 2019
fix(boilerplate): update pkg.engines.node requirement (#293)

fix(boilerplate): update pkg.engines.node requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants