Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cipher secret configurable #4

Open
wants to merge 29 commits into
base: preparation
Choose a base branch
from

Conversation

Chunlin-Li
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #4 into preparation will increase coverage by 0.29%.
The diff coverage is 89.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           preparation       #4      +/-   ##
===============================================
+ Coverage        84.15%   84.44%   +0.29%     
===============================================
  Files               62       61       -1     
  Lines             2127     2141      +14     
  Branches           388      394       +6     
===============================================
+ Hits              1790     1808      +18     
+ Misses             254      253       -1     
+ Partials            83       80       -3
Impacted Files Coverage Δ
...x-core/src/core/model/dw/sandboxGalaxySlsTraces.ts 100% <ø> (ø) ⬆️
...ages/sandbox-core/src/core/manager/errorManager.ts 94.11% <100%> (ø) ⬆️
...andbox-core/src/core/service/remoteDebugService.ts 93.54% <100%> (+0.69%) ⬆️
...s/sandbox-core/src/core/debugServer/debugServer.ts 93.87% <100%> (-0.38%) ⬇️
...ckages/sandbox-core/src/core/debugServer/cipher.ts 86.11% <80.95%> (-13.89%) ⬇️
...kages/sandbox-core/src/app/controller/errorCtrl.ts 93.75% <0%> (-1.57%) ⬇️
packages/sandbox-core/src/index.ts 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607af84...ce3a417. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants