-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't compile on go 1:57-3 #3
Comments
I haven't found the time to update it to the latest Go release. Looks like the crypto package has changed. mmikulicic reply@reply.github.com wrote:
|
@miekg, now they support Private keys with more than two factors. BTW, why do you generate them on your own, isn't there some library to do that for you? |
I've upgraded to release/release.r58 and everything compiles just thing now. Can you still not compile GoDNS? |
@miekg, I know, you pulled the fix from me ;-) I first reported it here, and then fixed it (hopefully). Do the tests compile? |
[ Quoting elazarl at 00:36 on July 5 in "Re: [godns] Doesn't compile on go 1"... ]
Ah, I remember, but I didn't close the issue :) Tests are now working, the non-working tests are disabled. I will grtz,
|
…kg#3) This gives the server operator a lot more flexibility as to how they manage the verification and generation of tsigs. The test TestServerRoundtripTsigProvider displays some of these possibilities. For example: 1. Establish a sync.RWMutex on the secret map so that secrets can be dynamically updated even after the server has been started. 2. Establish more granular secret maps. I.E to ensure that many zones can share TSIG names without collisions in the map. You could do other things like have zone specific verification or generation.
…kg#3) This gives the server operator a lot more flexibility as to how they manage the verification and generation of tsigs. The test TestServerRoundtripTsigProvider displays some of these possibilities. For example: 1. Establish a sync.RWMutex on the secret map so that secrets can be dynamically updated even after the server has been started. 2. Establish more granular secret maps. I.E to ensure that many zones can share TSIG names without collisions in the map. You could do other things like have zone specific verification or generation.
…kg#3) This gives the server operator a lot more flexibility as to how they manage the verification and generation of tsigs. The test TestServerRoundtripTsigProvider displays some of these possibilities. For example: 1. Establish a sync.RWMutex on the secret map so that secrets can be dynamically updated even after the server has been started. 2. Establish more granular secret maps. I.E to ensure that many zones can share TSIG names without collisions in the map. You could do other things like have zone specific verification or generation.
…kg#3) This gives the server operator a lot more flexibility as to how they manage the verification and generation of tsigs. The test TestServerRoundtripTsigProvider displays some of these possibilities. For example: 1. Establish a sync.RWMutex on the secret map so that secrets can be dynamically updated even after the server has been started. 2. Establish more granular secret maps. I.E to ensure that many zones can share TSIG names without collisions in the map. You could do other things like have zone specific verification or generation.
…kg#3) This gives the server operator a lot more flexibility as to how they manage the verification and generation of tsigs. The test TestServerRoundtripTsigProvider displays some of these possibilities. For example: 1. Establish a sync.RWMutex on the secret map so that secrets can be dynamically updated even after the server has been started. 2. Establish more granular secret maps. I.E to ensure that many zones can share TSIG names without collisions in the map. You could do other things like have zone specific verification or generation.
I applied the automated migrations with
for i in */.go; do gofix $i; done
but it still doesn't compile:
6g -o go.6 clientconfig.go client.go defaults.go dns.go dnssec.go edns.go keygen.go msg.go nsec3.go server.go tsig.go types.go xfr.go
client.go:152: label forever defined and not used
keygen.go:61: t.P undefined (type rsa.PrivateKey has no field or method P)
keygen.go:62: t.Q undefined (type *rsa.PrivateKey has no field or method Q)
keygen.go:67: t.P undefined (type *rsa.PrivateKey has no field or method P)
keygen.go:68: t.Q undefined (type *rsa.PrivateKey has no field or method Q)
keygen.go:71: t.Q undefined (type *rsa.PrivateKey has no field or method Q)
keygen.go:71: t.P undefined (type *rsa.PrivateKey has no field or method P)
keygen.go:131: p.P undefined (type *rsa.PrivateKey has no field or method P)
keygen.go:132: p.P undefined (type *rsa.PrivateKey has no field or method P)
keygen.go:135: p.Q undefined (type *rsa.PrivateKey has no field or method Q)
keygen.go:135: too many errors
make: ** [go.6] Error 1
The text was updated successfully, but these errors were encountered: