Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the IDN implementation necessary? #518

Closed
rolandshoemaker opened this issue Sep 18, 2017 · 4 comments
Closed

Is the IDN implementation necessary? #518

rolandshoemaker opened this issue Sep 18, 2017 · 4 comments

Comments

@rolandshoemaker
Copy link
Contributor

It appears to implement the RFC 3490-3492 series conversion which was obsoleted by the RFC 5890-5893 series which is implemented by the Golang eXtra package x/net/idna (which is pretty fully fleshed out and supports most of the added restriction profiles such as the Bidi rules etc).

@miekg
Copy link
Owner

miekg commented Sep 19, 2017

Maybe this has outlived is usefulness, or is it actually harming to keep this in?

cc @asergeyev

@andrewtj
Copy link
Collaborator

Two of the four issues I've opened have been closed following a switch to x/net/idna. The other two issues are at repos which don't seem to have much activity.

Given how quickly the two that switched made the jump I don't think removing IDN support would create much of a burden on any other users that might be out there.

@miekg
Copy link
Owner

miekg commented Nov 22, 2017 via email

miekg added a commit that referenced this issue Nov 24, 2017
Superseded by x/net/idna. It was useful, but not anymore; remove
entire directory.

Fixes #518
@miekg miekg mentioned this issue Nov 24, 2017
miekg added a commit that referenced this issue Nov 25, 2017
Superseded by x/net/idna. It was useful, but not anymore; remove
entire directory.

Fixes #518
@rekby
Copy link

rekby commented Feb 13, 2018

Thanks to question.
Lets-proxy has vendored dns package and remove idna will not broke my program.

I will switch to golang idna in near feature too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants