replace lodash clonedeep with merge-anything #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pr. The snyk security warning is for the I don't generally like to use less popular packages unless there is a good reason for it. Looking at the npms score, lodash.clonedeep has a higher score than merge-anything It also has more subdependencies. I'm not against replacing lodash.merge, but I don't really see a good reason in this case unless you can document why it's problematic |
|
ok no worries, I guess if there are future issues with it, there are some options available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces lodash with merge-anything, which is a fast, secure alternative to lodash. We constantly get security findings for anything related to lodash, whereas merge-anything seems to be ok.