Handle null and undefined in formatPercentage and formatWebsite #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuykendall
force-pushed
the
better-empty-checking
branch
from
ce0ccae
to
02d8d2e
Compare
ekatsuta
reviewed
Jan 28, 2020
| const EMPTY_VALUES = [ | ||
| ' ', | ||
| ' ', | ||
| '', |
There was a problem hiding this comment.
is there a reason for the different # of spaces in the empty string?
There was a problem hiding this comment.
Just seemed like a fun extra thing to test for. A very long but technically empty string. Not too dissimilar from ' ' but I have some code that strips the string down no matter the length so I wanted to test it.
A QA Engineer walks into a bar. The QA engineer orders a beer. Orders 0 beers. Orders 999999999 beers. Orders a lizard. Orders -1 beers. Orders a sfdeljknesv.
mumumumu
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.