Improve types and remove almost all any types #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuykendall
force-pushed
the
better-types
branch
from
eb2893a
to
e450473
Compare
rkuykendall
force-pushed
the
better-types
branch
from
e450473
to
0c60188
Compare
ellenshin
reviewed
Sep 20, 2021
| @@ -125,7 +125,7 @@ export function getNameOrDefault(obj?: unknown, { field = 'name', defaultValue = | |||
| return defaultValue; | |||
| } | |||
|
|
|||
| export function getOrDefault(value?: any) { | |||
| export function getOrDefault(value?: unknown) { | |||
There was a problem hiding this comment.
Just read a bit about unknown types. They are rly nice!
| export function getPercentValue(value?: null | string): string { | ||
| if (typeof value === 'undefined' || value === null || value === '') { | ||
| function _isDecimalValue(value: unknown): value is Decimal.Value { | ||
| return (isString(value) && value !== '') || isNumber(value) || Decimal.isDecimal(value); |
There was a problem hiding this comment.
A little confused here, how does checking if it is a string and not empty suffice for it being a Decimal.Value?
There was a problem hiding this comment.
You can see here the definition of Decimal.Value is string or number or Decimal
ellenshin
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed that
insertIfwasn't preserving types.Failing "tests" are just Coveralls downtime