Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some upstream standard rules are not properly propagated to their @typescript-eslint version #582

Closed
6XGate opened this issue May 27, 2021 · 7 comments · Fixed by #952
Closed

Some upstream standard rules are not properly propagated to their @typescript-eslint version #582

6XGate opened this issue May 27, 2021 · 7 comments · Fixed by #952

Comments

@6XGate
Copy link

6XGate commented May 27, 2021

What version of this package are you using? 20.0.0

What operating system, Node.js, and npm version? node v12.22.1 npm v7.14.0

What happened?
The following rules are defined in the upstream standard configuration but not propagated to their @typescript-eslint equivalents.

  • comma-dangle
  • no-loss-of-precision
  • no-implied-eval
  • no-loss-of-precision
  • object-curly-spacing
  • space-infix-ops

What did you expect to happen?
That the listed rules would be propagated to their TypeScript version and disabled.

Are you willing to submit a pull request to fix this bug?
maybe
@6XGate 6XGate changed the title Some **standard** rules are not properly propagated to their @typescript-eslint version Some upstream standard rules are not properly propagated to their @typescript-eslint version May 27, 2021
@6XGate 6XGate mentioned this issue May 28, 2021
Closed
@rsdmike
Copy link

rsdmike commented Oct 7, 2021 •
edited
Loading

It seems camelcase isn't defined as well?

@6XGate
Copy link
Author

6XGate commented Aug 26, 2022

@rsdmike, camelcase isn't part of the TypeScript ESLint rules. It's equivalent is naming-convention.

@mightyiam
Copy link
Owner

By the way, @rostislav-simonik and I are currently working on this.

@6XGate
Copy link
Author

6XGate commented Aug 26, 2022 •
edited
Loading

@mightyiam, I've got a much more complete form of my original PR's intension in scalecore/eslint-config-scalecore which handles propagation, conversion, and exclusion of rules enabled by eslint-config-standard, or any other configuration.
It's develop branch is even more complete.

@mightyiam
Copy link
Owner

@6XGate I have a feeling that @rostislav-simonik and I doing this ourselves would end up being an effort similar to reading your code and trying to adapt it to our purpose. Or perhaps less of an effort, due to reduced context in comparison.

Another option is for you to join us in our mob programming sessions. Three is a real mob.

@6XGate
Copy link
Author

6XGate commented Aug 26, 2022

I could try tackling that Monday after I'm back home.

@6XGate
Copy link
Author

6XGate commented Aug 29, 2022

I just pushed an update to the #583 pull request that should propagate all rules @typescript-eslint indicates are extension or replacement rules.

mightyiam added a commit that referenced this issue Sep 13, 2022
@mightyiam @rostislav-simonik
feat: use all typescript-eslint equivalents
db53a7b 
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens,
no-loss-of-precision, object-curly-spacing, space-before-blocks,
comma-dangle.

Closes #582, closes #583.

Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
@mightyiam mightyiam mentioned this issue Sep 13, 2022
Merged
mightyiam added a commit that referenced this issue Sep 13, 2022
@mightyiam @rostislav-simonik
feat: use all typescript-eslint equivalents
7bce98f 
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens,
no-loss-of-precision, object-curly-spacing, space-before-blocks,
comma-dangle.

Closes #582, closes #583.

Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
mightyiam added a commit that referenced this issue Sep 13, 2022
@mightyiam @rostislav-simonik
feat: use all typescript-eslint equivalents
1e8764d 
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens,
no-loss-of-precision, object-curly-spacing, space-before-blocks,
comma-dangle.

Closes #582, closes #583.

Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
eslint-config-love-release-bot bot pushed a commit that referenced this issue Sep 13, 2022
@semantic-release-bot
chore(release): 23.0.0 [skip ci]
c5b4f8b 
## [23.0.0](v22.0.0...v23.0.0) (2022-09-13)

### ⚠ BREAKING CHANGES

* add rules from @typescript-eslint: no-extra-parens,
no-loss-of-precision, object-curly-spacing, space-before-blocks,
comma-dangle.

### Features

* use all typescript-eslint equivalents ([1e8764d](1e8764d)), closes [#582](#582) [#583](#583)

### CI

* continuous delivery ([971c680](971c680)), closes [#840](#840)

### Build system / dependencies

* renovate automergeMinor github actions ([02dde9d](02dde9d)), closes [#910](#910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use all typescript-eslint equivalents mightyiam/eslint-config-love
3 participants
@mightyiam @6XGate @rsdmike