Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a blunder in a1f57a5 when I used
timeout is 10
instead oftimeout == 10
. Python (rightly) complains about this withSyntaxWarning: "is" with a literal. Did you mean "=="?
It also seems to me that extending
urllib.parse.uses_netloc
isn't necessary (anymore?). All tests still pass when removing the relevant code. I stumbled upon this becausesubmission
was missing from the list and it still worked and I didn't find the place where thesubmission
protocol was replaced by a known protocol. Removing code is good and removing code which modifies global state is even better.Thanks again for the package!