Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in tests/helpers/test_log.py fail after switching to daylight saving time on March 26th #68

Closed
patrikspiess opened this issue Mar 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@patrikspiess
Copy link
Member

>       assert syslog_formatter.format(log_record) == expected_string
E       AssertionError: assert '<10>1 1970-0... test_message' == '<10>1 1970-0... test_message'
E         Skipping 55 identical trailing characters in diff, use -v to show
E         - <10>1 1970-01-01T01:00:00+02:00 dummy
E         ?                            ^
E         + <10>1 1970-01-01T01:00:00+01:00 dummy
E         ?                            ^

Wouldn't it be better to check the time format with a regex instead of a fully qualified string?

@patrikspiess patrikspiess added the bug Something isn't working label Mar 28, 2023
@patrikspiess patrikspiess changed the title Test sin tests/helpers/test_log.py fails after switching to daylight saving time on March 26th Tests in tests/helpers/test_log.py fail after switching to daylight saving time on March 26th Mar 28, 2023
lucmurer added a commit that referenced this issue Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant