feat(useselectionstate): add useSelectionState hook, stories and test stubs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-18-preview.surge.sh ✨ |
|
This one doesn't have unit tests, I left stubs in there for later, but I need to get moving with other work so I opened an issue for it: #19 |
ibolton336
approved these changes
Aug 28, 2020
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding one of the custom hooks I introduced in virt-ui, so I can mess with the usage of hooks in Storybook stories.
Turns out you can't use TypeScript directly in an MDX file, but Storybook supports importing the body of a story from another file.
I'll leave the rest of #12 for another day so I can get back to working on virt-ui.