Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statusIcon) Enhance StatusIcon with Info status #30

Merged
merged 4 commits into from
Oct 30, 2020
Merged

feat(statusIcon) Enhance StatusIcon with Info status #30

merged 4 commits into from
Oct 30, 2020

Conversation

gildub
Copy link
Collaborator

@gildub gildub commented Oct 29, 2020

Adds an info status

Resolves #29

Would help with kubev2v/forklift-ui#163

@gildub gildub requested a review from a team October 29, 2020 11:28
@konveyor-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-30-preview.surge.sh

@gildub gildub changed the title RFE for StatusIcon Enhance StatusIcon with Info status Oct 29, 2020
@mturley
Copy link
Collaborator

mturley commented Oct 29, 2020

btw @gildub we need to put the feat(*) prefix in the PR title here so that merging it will properly trigger semantic-release

@gildub gildub changed the title Enhance StatusIcon with Info status feat(*) Enhance StatusIcon with Info status Oct 29, 2020
Specify 1em diameter on the spinner so it will always match the icon size
@gildub gildub changed the title feat(*) Enhance StatusIcon with Info status feat(statusIcon) Enhance StatusIcon with Info status Oct 30, 2020
@mturley mturley merged commit a3ea372 into migtools:master Oct 30, 2020
@konveyor-release-bot
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gildub gildub deleted the statusicon-info-spin branch January 7, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "info" variant to the StatusIcon component
4 participants