fix(useformstate): hotfix: we needed AnySchema<T> instead of SchemaOf<T> for the yup breaking change #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…<T> for the yup breaking change BREAKING CHANGE: useFormState and useFormField now require `yup.AnySchema<T>` schema types instead of the `yup.SchemaOf<T>` which was not behaving correctly with boolean fields.
|
🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-59-preview.surge.sh ✨ |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 19 19
Branches 5 5
=========================================
Hits 19 19 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up in #57.
useFormState and useFormField now require
yup.AnySchema<T>schema types instead of theyup.SchemaOf<T>which was not behaving correctly with boolean fields.