Add namespace property for compatibility with Gradle 8 #1274
Conversation
| @@ -1,2 +1,3 @@ | |||
| org.gradle.jvmargs=-Xmx1536M | |||
| android.enableR8=true | |||
There was a problem hiding this comment.
enableR8 is deprecated, and I got a warning for the missing useAndroidX
| @@ -24,6 +23,7 @@ | |||
| android:theme="@style/LaunchTheme" | |||
| android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection|fontScale|screenLayout|density" | |||
| android:hardwareAccelerated="true" | |||
| android:exported="true" | |||
There was a problem hiding this comment.
This prevented building the example app
| @@ -30,6 +30,6 @@ subprojects { | |||
| project.evaluationDependsOn(':app') | |||
| } | |||
|
|
|||
| task clean(type: Delete) { | |||
| tasks.register("clean", Delete) { | |||
There was a problem hiding this comment.
This is new in newer Gradle versions, was automatically added by the Flutter tool migrators.
| @@ -9,8 +9,6 @@ dependencies: | |||
| flutter: | |||
| sdk: flutter | |||
|
|
|||
| cupertino_icons: ^0.1.2 | |||
There was a problem hiding this comment.
cupertino_icons was never used and the old version prevented running in null-safe mode.
|
I actually misread the changelog here. Migrating specifically to Gradle 8, requires the source compatibility to change to Java 17, which is not what we want. I'll revert the Gradle 8 change and keep the namespace changes (the latter is what we actually want per https://docs.flutter.dev/release/breaking-changes/android-java-gradle-migration-guide) |
navaronbracke
changed the title
|
Thank you, could you bump it to 5.3.0 instead, since it could break stuff for projects relying on older gradle versions? |
|
@miguelpruivo Done! |
This PR updates Gradle to version 8.0
Fixes #1273