Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save file to mobile platforms. #1452

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Conversation

Samoy
Copy link
Contributor

@Samoy Samoy commented Mar 3, 2024

User can save file to mobile platforms with bytes. Desktop platforms remain unchanged.

@Samoy Samoy changed the title Save file to mobile platform. Save file to mobile platforms. Mar 3, 2024
Copy link
Owner

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good. Can you please update the major version and changelog accordingly?

# Conflicts:
#	android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerDelegate.java
@Samoy Samoy reopened this Mar 5, 2024
@Samoy Samoy requested a review from miguelpruivo March 15, 2024 01:33
Copy link
Owner

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelpruivo
Copy link
Owner

@Samoy there are just a few imports conflicts, could you please address it so I can merge?

Thanks.

@miguelpruivo miguelpruivo added android Issue applies to Android platform improvement Improvement needed on a specific feature labels Mar 20, 2024
@Samoy
Copy link
Contributor Author

Samoy commented Mar 20, 2024

@miguelpruivo OK

@Samoy there are just a few imports conflicts, could you please address it so I can merge?

Thanks.

Ok, it has been resolved.

@miguelpruivo miguelpruivo merged commit a84f497 into miguelpruivo:master Mar 20, 2024
0 of 2 checks passed
@miguelpruivo
Copy link
Owner

miguelpruivo commented Mar 20, 2024

Merged, thanks! It'll be available in the 7.1.0 later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issue applies to Android platform improvement Improvement needed on a specific feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants