Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WMS Provider, added support for POST data. #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dzwarg
Copy link

@dzwarg dzwarg commented Dec 14, 2011

Hello migurski,

I added a WMS provider to modestmaps-py. I modeled it closely after the examples I saw for the as3 version, but removed the bounds checking.

In addition to the new provider, I added support for POST-able data. In my use case, I needed to send SLD_BODY content to the WMS map server when generating the images. This was a very small change to the Provider base (I removed some redundant methods), and some simple checks in the Tile load method.

In addition, I changed the default mode of the tile images to be 'RGBA', since sometimes the alpha channel is important, when generating overlays, for example.

Thanks,
dzwarg

@migurski
Copy link
Owner

Thanks! Do you have a WMS server I can use to test this before I merge?

@dzwarg
Copy link
Author

dzwarg commented Dec 21, 2011

I'm looking into finding one. I'll let you know shortly.

@dzwarg
Copy link
Author

dzwarg commented Dec 21, 2011

Hello migurski,

I added a public WMS server test to my repo: dzwarg/modestmaps-py, in the wms_test.py script.

This test fetches and draws one map with the default styling, then uses an SLD with the inverted rule set to render the second.

Is this what you need to test, or do you need more information?

Thanks,
dzwarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants